Skip to content

Commit 9bd02bf

Browse files
committed
add more fixme details
1 parent 027d2a1 commit 9bd02bf

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/reactpy_django/components.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,9 +328,12 @@ def _python_to_pyscript(
328328
new_config = extend_pyscript_config(config, extra_packages)
329329

330330
if not rendered:
331-
# FIXME: This is needed to properly kill off any previous PyScript instances
332-
# such as when a component is re-rendered due to WebSocket disconnection.
333-
# There may be a better way to do this, but it's not clear at the moment
331+
# FIXME: This is needed to properly re-render PyScript instances such as
332+
# when a component is re-rendered due to WebSocket disconnection.
333+
# There may be a better way to do this in the future.
334+
# While this solution allows re-creating PyScript components, it also
335+
# results in a browser memory leak. It currently unclear how to properly
336+
# clean up unused code (def user_workspace_UUID) from PyScript.
334337
set_rendered(True)
335338
return None
336339

0 commit comments

Comments
 (0)