From 9edbabaecdc7525737d91d173bba525073460862 Mon Sep 17 00:00:00 2001 From: Steve Jones Date: Mon, 6 Jan 2025 17:55:41 +0000 Subject: [PATCH 1/2] Fix link event to reference currentTarget --- src/reactpy_router/static/link.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/reactpy_router/static/link.js b/src/reactpy_router/static/link.js index 9f78cc5..7ab069b 100644 --- a/src/reactpy_router/static/link.js +++ b/src/reactpy_router/static/link.js @@ -4,7 +4,7 @@ document.querySelector(".UUID").addEventListener( // Prevent default if ctrl isn't pressed if (!event.ctrlKey) { event.preventDefault(); - let to = event.target.getAttribute("href"); + let to = event.currentTarget.getAttribute("href"); let new_url = new URL(to, window.location); // Deduplication needed due to ReactPy rendering bug From fec6d166d5f96a4dd4f1ee84ec6b79d1d2d5528b Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Mon, 6 Jan 2025 17:46:32 -0800 Subject: [PATCH 2/2] Add changelog item --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e3fa727..6658cea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,10 @@ Using the following categories, list your changes in this order: - Set upper limit on ReactPy version to `<2.0.0`. +### Fixed + +- Fixed bug where `link` element sometimes would sometimes not retrieve the correct `href` attribute. + ## [1.0.3] - 2024-11-21 ### Fixed