Fix flaky test: ESM module loading race condition in test_subcomponent_notation (#1315)

Copilot · Archmonger · web-flow · commit 84e124616cbd · 2025-12-11T17:15:52.000-08:00
Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: Archmonger &lt;16909269+Archmonger@users.noreply.github.com&gt;
diff --git a/tests/test_reactjs/js_fixtures/subcomponent-notation.js b/tests/test_reactjs/js_fixtures/subcomponent-notation.js
@@ -1,6 +1,9 @@
-import React from "https://esm.sh/react@19.0"
-import ReactDOM from "https://esm.sh/react-dom@19.0/client"
-import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
+import React from "https://esm.sh/v135/react@19.0"
+import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
+// Explicitly import react-is to ensure it's loaded before react-bootstrap
+// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
+import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
+import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
 export {InputGroup, Form};
 
 export function bind(node, config) {
diff --git a/tests/test_web/js_fixtures/subcomponent-notation.js b/tests/test_web/js_fixtures/subcomponent-notation.js
@@ -1,6 +1,9 @@
-import React from "https://esm.sh/react@19.0"
-import ReactDOM from "https://esm.sh/react-dom@19.0/client"
-import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
+import React from "https://esm.sh/v135/react@19.0"
+import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
+// Explicitly import react-is to ensure it's loaded before react-bootstrap
+// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
+import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
+import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
 export {InputGroup, Form};
 
 export function bind(node, config) {

-Original file line number
+Diff line change
@@ @@ -1,6 +1,9 @@ @@
 -import React from "https://esm.sh/[email protected]"
 -import ReactDOM from "https://esm.sh/[email protected]/client"
 -import {InputGroup, Form} from "https://esm.sh/[email protected][email protected],[email protected],[email protected]&exports=InputGroup,Form";
 +import React from "https://esm.sh/v135/[email protected]"
 +import ReactDOM from "https://esm.sh/v135/[email protected]/client"
 +// Explicitly import react-is to ensure it's loaded before react-bootstrap
 +// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
 +import * as ReactIs from "https://esm.sh/v135/[email protected]"
 +import {InputGroup, Form} from "https://esm.sh/v135/[email protected][email protected],[email protected],[email protected]&exports=InputGroup,Form";
 export {InputGroup, Form};
 export function bind(node, config) {