Skip to content

Commit b8b8bc5

Browse files
authored
Merge branch 'main' into main
2 parents c291e9c + bca508e commit b8b8bc5

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

.github/ISSUE_TEMPLATE/issue-form.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Plan a Task
22
description: Create a detailed plan of action (ONLY START AFTER DISCUSSION PLEASE 🙏).
3-
labels: [triage]
3+
labels: ["flag: triage"]
44
body:
55
- type: textarea
66
attributes:

requirements/check-style.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
black
22
flake8
3-
flake8-print
4-
pep8-naming
53
flake8-idom-hooks >=0.5.0
4+
flake8-print
5+
flake8-tidy-imports
66
isort >=5.7.0
7+
pep8-naming

setup.cfg

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ exclude =
1616
**/node_modules/*
1717
.eggs/*
1818
.tox/*
19+
# -- flake8-tidy-imports --
20+
ban-relative-imports = parents
1921

2022
[tool:pytest]
2123
testpaths = tests

src/idom/web/module.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,25 +252,25 @@ class WebModule:
252252
def export(
253253
web_module: WebModule,
254254
export_names: str,
255-
fallback: Optional[Any],
256-
allow_children: bool,
255+
fallback: Optional[Any] = ...,
256+
allow_children: bool = ...,
257257
) -> _VdomDictConstructor:
258258
...
259259

260260

261261
@overload
262262
def export(
263263
web_module: WebModule,
264-
export_names: Union[List[str], Tuple[str]],
265-
fallback: Optional[Any],
266-
allow_children: bool,
264+
export_names: Union[List[str], Tuple[str, ...]],
265+
fallback: Optional[Any] = ...,
266+
allow_children: bool = ...,
267267
) -> List[_VdomDictConstructor]:
268268
...
269269

270270

271271
def export(
272272
web_module: WebModule,
273-
export_names: Union[str, List[str], Tuple[str]],
273+
export_names: Union[str, List[str], Tuple[str, ...]],
274274
fallback: Optional[Any] = None,
275275
allow_children: bool = True,
276276
) -> Union[_VdomDictConstructor, List[_VdomDictConstructor]]:

0 commit comments

Comments
 (0)