Add feature pinch to zoom#1685
Conversation
…ol good thing the root is easilly accessible. Works but not the best. WIP2
…sheds becasue of animation intialized wron
…orpertyValuesHolder isnt null. ZoomLayout no sbehaves smoothly. Verified the pinch to zoom gesture on real device and works without crashes.This commit should close recloudstream#1619
|
While I really appreciate this pull request, I meant it more like a pinch-to-zoom like it is on YouTube and not app wide zoom. An app wide zoom can be provided by the operating systems accessibility settings, so I do not believe this implementation is fit for CloudStream. I now see the discussion in the issue, and realize that I misinterpreted the original intent, but see #987 #999 |
|
I believe that you can still continue with this pull request if you move the zoom into the videoplayer xmls, and instead of resetting when releasing only reset when you zoom out (to less then 100%, as no user would want to minimize the app). That way users can set a zoom for a movie without having to hold it. Also, it might be interesting to only allow zoom changes when the videoplayer is not locked, |
|
Alright I will look into it! |
Yeah. I mentioned this to them in a reply on the original issue, but I guess they didn't see it: #1619 (comment) |
This pull reuquest should close #1619 . It adds A class that wraps the activity_main.xml layout, successfully enabling gesture based zooming. It also has smooth transitioning back to the view's original size to not mess with the core and feel of the ui. Was tested on both an emulator and a real device.
Below is a demonstration of it working.
https://github.com/user-attachments/assets/5a03d286-67c8-4b6b-abac-13096a827218