[PHPUnit] Support list in YieldDataProviderRector (#418)

* [PHPUnit] Support list in YieldDataProviderRector

* cs

Author: staabm

rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc

@@ -20,6 +20,7 @@ final class UseDataProviderTestPhpdoc extends TestCase
         ];
     }
 
+    /** @return list<array<string>> */
     public static function dataProvider()
     {
         return [
@@ -51,6 +52,7 @@ final class UseDataProviderTestPhpdoc extends TestCase
         yield ['<?php implode("", $foo, );', '<?php implode($foo, "", );'];
     }
 
+    /** @return \Iterator<int<0, max>, array<string>> */
     public static function dataProvider(): \Iterator
     {
         yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];

rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php

@@ -11,7 +11,6 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Return_;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
-use PHPStan\Type\ArrayType;
 use PHPStan\Type\Generic\GenericObjectType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
@@ -177,7 +176,7 @@ private function removeReturnTag(ClassMethod $classMethod): void
             return;
         }
 
-        if ($phpDocInfo->getReturnType() instanceof ArrayType) {
+        if ($phpDocInfo->getReturnType()->isArray()->yes()) {
             $keyType = $phpDocInfo->getReturnType()
                 ->getIterableKeyType();
             $itemType = $phpDocInfo->getReturnType()