[internal] Make consistent to continue outer loop when subnode type changed on AbstractImmutableNodeTraverser

samsonasik · samsonasik · commit 136d883cf333 · 2025-12-22T08:52:21.000+07:00
diff --git a/src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php b/src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php
@@ -114,7 +114,7 @@ protected function traverseNode(Node $node): void
 
                         if ($originalSubNodeClass !== $subNode::class) {
                             // stop traversing as node type changed and visitors won't work
-                            return;
+                            continue 2;
                         }
 
                     } elseif ($return === NodeVisitor::DONT_TRAVERSE_CHILDREN) {

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ protected function traverseNode(Node $node): void`
`114`	`114`
`115`	`115`	`if ($originalSubNodeClass !== $subNode::class) {`
`116`	`116`	`// stop traversing as node type changed and visitors won't work`
`117`		`- return;`
	`117`	`+ continue 2;`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`} elseif ($return === NodeVisitor::DONT_TRAVERSE_CHILDREN) {`