Skip to content

Commit 5697100

Browse files
authored
[CodingStyle] Skip compare binary op on BinaryOpStandaloneAssignsToDirectRector (#7470)
* [CodingStyle] Skip compare binary op on BinaryOpStandaloneAssignsToDirectRector * fix
1 parent 3500794 commit 5697100

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?php
2+
3+
namespace Rector\Tests\CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector\Fixture;
4+
5+
final class SkipCompareAssignOp
6+
{
7+
public function run($first, $second)
8+
{
9+
$first += 1 + 1 + 1 + 1 +1 + 1 + 1 + 1 + 1 + 1;
10+
$second += 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2;
11+
12+
return $first <=> $second;
13+
}
14+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?php
2+
3+
namespace Rector\Tests\CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector\Fixture;
4+
5+
final class SkipCompareBinaryOp
6+
{
7+
public function run()
8+
{
9+
$first = 1 + 1 + 1 + 1 +1 + 1 + 1 + 1 + 1 + 1;
10+
$second = 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2;
11+
12+
return $first <=> $second;
13+
}
14+
}

rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,10 @@ private function matchToVariableAssignExpr(Stmt $stmt): ?VariableAndExprAssign
137137
return null;
138138
}
139139

140+
if ($assign->expr instanceof BinaryOp) {
141+
return null;
142+
}
143+
140144
return new VariableAndExprAssign($assign->var, $assign->expr);
141145
}
142146
}

0 commit comments

Comments
 (0)