cache reflection

Author: TomasVotruba

src/Reflection/ReflectionResolver.php

@@ -37,14 +37,19 @@
 use Rector\StaticTypeMapper\ValueObject\Type\ShortenedObjectType;
 use Rector\ValueObject\MethodName;
 
-final readonly class ReflectionResolver
+final class ReflectionResolver
 {
+    /**
+     * @var array<string, MethodReflection|FunctionReflection|null>
+     */
+    private array $reflectionByHash = [];
+
     public function __construct(
-        private ReflectionProvider $reflectionProvider,
-        private NodeTypeResolver $nodeTypeResolver,
-        private NodeNameResolver $nodeNameResolver,
-        private ClassAnalyzer $classAnalyzer,
-        private MethodReflectionResolver $methodReflectionResolver
+        private readonly ReflectionProvider $reflectionProvider,
+        private readonly NodeTypeResolver $nodeTypeResolver,
+        private readonly NodeNameResolver $nodeNameResolver,
+        private readonly ClassAnalyzer $classAnalyzer,
+        private readonly MethodReflectionResolver $methodReflectionResolver
     ) {
     }
 
@@ -196,23 +201,37 @@ public function resolveMethodReflectionFromMethodCall(MethodCall $methodCall): ?
     public function resolveFunctionLikeReflectionFromCall(
         CallLike $callLike
     ): MethodReflection | FunctionReflection | null {
+        // cache here
+        $callLikeHash = spl_object_hash($callLike);
+        if ($this->reflectionByHash[$callLikeHash] ?? null) {
+            return $this->reflectionByHash[$callLikeHash];
+        }
+
         if ($callLike instanceof MethodCall) {
-            return $this->resolveMethodReflectionFromMethodCall($callLike);
+            $reflection = $this->resolveMethodReflectionFromMethodCall($callLike);
+            $this->reflectionByHash[$callLikeHash] = $reflection;
+
+            return $reflection;
         }
 
         if ($callLike instanceof StaticCall) {
-            return $this->resolveMethodReflectionFromStaticCall($callLike);
+            $reflection = $this->resolveMethodReflectionFromStaticCall($callLike);
+            $this->reflectionByHash[$callLikeHash] = $reflection;
+            return $reflection;
         }
 
         if ($callLike instanceof New_) {
-            return $this->resolveMethodReflectionFromNew($callLike);
+            $reflection = $this->resolveMethodReflectionFromNew($callLike);
+            $this->reflectionByHash[$callLikeHash] = $reflection;
+            return $reflection;
         }
 
         if ($callLike instanceof FuncCall) {
-            return $this->resolveFunctionReflectionFromFuncCall($callLike);
+            $reflection = $this->resolveFunctionReflectionFromFuncCall($callLike);
+            $this->reflectionByHash[$callLikeHash] = $reflection;
+            return $reflection;
         }
 
-        // todo: support NullsafeMethodCall
         return null;
     }
 

src/StaticTypeMapper/Resolver/ClassNameFromObjectTypeResolver.php

@@ -11,7 +11,6 @@ final class ClassNameFromObjectTypeResolver
     public static function resolve(Type $type): ?string
     {
         $objectClassNames = $type->getObjectClassNames();
-
         if (count($objectClassNames) !== 1) {
             return null;
         }