[comp] Restore FirstClassCallableRector and make it explicitly deprecated, to ease transition

Author: TomasVotruba

phpstan.neon

@@ -433,3 +433,12 @@ parameters:
                 - rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
                 - rules/Php81/Enum/AttributeName.php
 
+        # deprecated rule
+        - '#Rule Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector must implements Rector\\VersionBonding\\Contract\\MinPhpVersionInterface#'
+        - '#Register "Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector" service to "php81\.php" config set#'
+        - '#Access to constant on deprecated class Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector#'
+        -
+            message: '#Only abstract classes can be extended#'
+            path: rules/Php81/Rector/Array_/FirstClassCallableRector.php
+
+

rector.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use Rector\CodingStyle\Rector\FunctionLike\FunctionLikeToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
@@ -42,9 +41,6 @@
     ->withImportNames(removeUnusedImports: true)
     ->withRules([RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class])
     ->withSkip([
-        // testing skip of deprecated class
-        FunctionLikeToFirstClassCallableRector::class,
-
         StringClassNameToClassConstantRector::class,
         // tests
         '*/Fixture*',

rules/Php81/Rector/Array_/ArrayToFirstClassCallableRector.php

@@ -31,7 +31,7 @@
  * @see RFC https://wiki.php.net/rfc/first_class_callable_syntax
  * @see \Rector\Tests\Php81\Rector\Array_\ArrayToFirstClassCallableRector\ArrayToFirstClassCallableRectorTest
  */
-final class ArrayToFirstClassCallableRector extends AbstractRector implements MinPhpVersionInterface
+class ArrayToFirstClassCallableRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
         private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher,

rules/Php81/Rector/Array_/FirstClassCallableRector.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php81\Rector\Array_;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\StaticCall;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
+
+/**
+ * @deprecated Renamed to \Rector\Php81\Rector\Array_\ArrayToFirstClassCallableRector
+ */
+final class FirstClassCallableRector extends ArrayToFirstClassCallableRector implements DeprecatedInterface
+{
+    public function refactor(Node $node): StaticCall|MethodCall|null
+    {
+        throw new ShouldNotHappenException(sprintf(
+            '%s is deprecated and renamed to "%s". Use it instead.',
+            self::class,
+            ArrayToFirstClassCallableRector::class
+        ));
+    }
+}

src/Skipper/SkipCriteriaResolver/SkippedClassResolver.php

@@ -15,24 +15,25 @@
 final class SkippedClassResolver
 {
     /**
-     * @var null|array<string, string[]|null>
+     * @var null|array<class-string, string[]|null>
      */
     private null|array $skippedClassesToFiles = null;
 
     /**
-     * @return array<DeprecatedInterface>
+     * @return array<class-string<DeprecatedInterface>>
      */
     public function resolveDeprecatedSkippedClasses(): array
     {
         $skippedClassNames = array_keys($this->resolve());
 
-        return array_filter($skippedClassNames, function (string $class): bool {
-            return is_a($class, DeprecatedInterface::class, true);
-        });
+        return array_filter(
+            $skippedClassNames,
+            fn (string $class): bool => is_a($class, DeprecatedInterface::class, true)
+        );
     }
 
     /**
-     * @return array<string, string[]|null>
+     * @return array<class-string, string[]|null>
      */
     public function resolve(): array
     {