add static all support to AddReturnDocblockFromMethodCallDocblockRector

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector/Fixture/handle_static_call.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockFromMethodCallDocblockRector\Fixture;
+
+use Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockFromMethodCallDocblockRector\Source\SomeRepository;
+
+final class HandleStaticCall
+{
+    public function getAll(): array
+    {
+        return SomeRepository::staticFindAll();
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockFromMethodCallDocblockRector\Fixture;
+
+use Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockFromMethodCallDocblockRector\Source\SomeRepository;
+
+final class HandleStaticCall
+{
+    /**
+     * @return SomeEntity[]
+     */
+    public function getAll(): array
+    {
+        return SomeRepository::staticFindAll();
+    }
+}
+
+?>

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector/Source/SomeRepository.php

@@ -21,4 +21,12 @@ public function findAllWithoutArray()
     {
         return [];
     }
+
+    /**
+     * @return SomeEntity[]
+     */
+    public static function staticFindAll(): array
+    {
+        return [];
+    }
 }

rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Return_;
@@ -116,14 +117,16 @@ public function refactor(Node $node): ?Node
         }
 
         $onlyReturnWithExpr = $this->returnNodeFinder->findOnlyReturnWithExpr($node);
-        if (! $onlyReturnWithExpr instanceof Return_ || ! $onlyReturnWithExpr->expr instanceof MethodCall) {
+        if (! $onlyReturnWithExpr instanceof Return_ || (! $onlyReturnWithExpr->expr instanceof MethodCall && ! $onlyReturnWithExpr->expr instanceof StaticCall)) {
             return null;
         }
 
         $returnedMethodCall = $onlyReturnWithExpr->expr;
 
         // skip doctrine connection calls, as to generic and not helpful
-        $callerType = $this->getType($returnedMethodCall->var);
+        $callerType = $this->getType(
+            $returnedMethodCall instanceof MethodCall ? $returnedMethodCall->var : $returnedMethodCall->class
+        );
         if ($callerType instanceof ObjectType && $callerType->isInstanceOf(DoctrineClass::CONNECTION)->yes()) {
             return null;
         }