[cleanup] deprecate SHOULD_KEEP_PRE_SLASH, remove dont traverse const on StringClassNameToClassConstantRector

Author: TomasVotruba

phpstan.neon

@@ -392,6 +392,5 @@ parameters:
         -
             identifier: rector.noIntegerRefactorReturn
             paths:
-                - rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
                 - rules/Php80/Rector/Switch_/ChangeSwitchToMatchRector.php
                 - tests/Issues/InfiniteLoop/Rector/MethodCall/InfinityLoopRector.php

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/FixtureKeepPreSlash/pre_slash.php.inc

@@ -5,14 +5,12 @@
 namespace Rector\Php55\Rector\String_;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\ClassConstFetch;
-use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\String_;
-use PhpParser\NodeVisitor;
 use PHPStan\Reflection\ReflectionProvider;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -26,6 +24,7 @@
 final class StringClassNameToClassConstantRector extends AbstractRector implements MinPhpVersionInterface, ConfigurableRectorInterface
 {
     /**
+     * @deprecated since 2.2.12. Default behavior now.
      * @var string
      */
     public const SHOULD_KEEP_PRE_SLASH = 'should_keep_pre_slash';
@@ -35,8 +34,6 @@ final class StringClassNameToClassConstantRector extends AbstractRector implemen
      */
     private array $classesToSkip = [];
 
-    private bool $shouldKeepPreslash = false;
-
     public function __construct(
         private readonly ReflectionProvider $reflectionProvider,
     ) {
@@ -74,11 +71,7 @@ public function run()
 }
 CODE_SAMPLE
                 ,
-                [
-                    'ClassName',
-                    'AnotherClassName',
-                    self::SHOULD_KEEP_PRE_SLASH => false,
-                ],
+                ['ClassName', 'AnotherClassName'],
             ),
         ]);
     }
@@ -88,21 +81,15 @@ public function run()
      */
     public function getNodeTypes(): array
     {
-        return [String_::class, FuncCall::class];
+        return [String_::class];
     }
 
     /**
-     * @param String_|FuncCall $node
-     * @return Concat|ClassConstFetch|null|NodeVisitor::DONT_TRAVERSE_CHILDREN
+     * @param String_ $node
      */
-    public function refactor(Node $node): Concat|ClassConstFetch|null|int
+    public function refactor(Node $node): ClassConstFetch|null
     {
-        // keep allowed string as condition
-        if ($node instanceof FuncCall) {
-            if ($this->isName($node, 'is_a')) {
-                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-            }
-
+        if ($this->shouldSkipIsA($node)) {
             return null;
         }
 
@@ -119,14 +106,6 @@ public function refactor(Node $node): Concat|ClassConstFetch|null|int
         }
 
         $fullyQualified = new FullyQualified($classLikeName);
-        if ($this->shouldKeepPreslash && $classLikeName !== $node->value) {
-            $preSlashCount = strlen($node->value) - strlen($classLikeName);
-            $preSlash = str_repeat('\\', $preSlashCount);
-            $string = new String_($preSlash);
-
-            return new Concat($string, new ClassConstFetch($fullyQualified, 'class'));
-        }
-
         return new ClassConstFetch($fullyQualified, 'class');
     }
 
@@ -135,13 +114,6 @@ public function refactor(Node $node): Concat|ClassConstFetch|null|int
      */
     public function configure(array $configuration): void
     {
-        if (isset($configuration[self::SHOULD_KEEP_PRE_SLASH]) && is_bool(
-            $configuration[self::SHOULD_KEEP_PRE_SLASH]
-        )) {
-            $this->shouldKeepPreslash = $configuration[self::SHOULD_KEEP_PRE_SLASH];
-            unset($configuration[self::SHOULD_KEEP_PRE_SLASH]);
-        }
-
         Assert::allString($configuration);
 
         $this->classesToSkip = $configuration;
@@ -184,4 +156,15 @@ private function shouldSkip(string $classLikeName): bool
 
         return false;
     }
+
+    private function shouldSkipIsA(String_ $string): bool
+    {
+        if (! $string->getAttribute(AttributeKey::IS_ARG_VALUE, false)) {
+            return false;
+        }
+
+        $funcCallName = $string->getAttribute(AttributeKey::FROM_FUNC_CALL_NAME);
+
+        return $funcCallName === 'is_a';
+    }
 }

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/KeepPreSlashTest.php

@@ -5,8 +5,6 @@
 namespace Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\Array_;
-use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\NodeVisitorAbstract;
@@ -32,14 +30,7 @@ public function enterNode(Node $node): ?Node
 
         $funcCallName = $node->name->toString();
         foreach ($node->getArgs() as $arg) {
-            if ($arg->value instanceof Array_) {
-                $arg->value->setAttribute(AttributeKey::FROM_FUNC_CALL_NAME, $funcCallName);
-                continue;
-            }
-
-            if ($arg->value instanceof ArrayDimFetch) {
-                $arg->value->setAttribute(AttributeKey::FROM_FUNC_CALL_NAME, $funcCallName);
-            }
+            $arg->value->setAttribute(AttributeKey::FROM_FUNC_CALL_NAME, $funcCallName);
         }
 
         return null;