[ci-review] Rector Rectify

Author: actions-user

rules/CodingStyle/Guard/ArrowFunctionAndClosureFirstClassCallableGuard.php

@@ -26,13 +26,13 @@
 use Rector\PhpParser\Comparing\NodeComparator;
 use Rector\Reflection\ReflectionResolver;
 
-final class ArrowFunctionAndClosureFirstClassCallableGuard
+final readonly class ArrowFunctionAndClosureFirstClassCallableGuard
 {
     public function __construct(
-        private readonly ReflectionResolver $reflectionResolver,
-        private readonly AstResolver $astResolver,
-        private readonly NodeComparator $nodeComparator,
-        private readonly NodeNameResolver $nodeNameResolver,
+        private ReflectionResolver $reflectionResolver,
+        private AstResolver $astResolver,
+        private NodeComparator $nodeComparator,
+        private NodeNameResolver $nodeNameResolver,
     ) {
 
     }
@@ -123,7 +123,7 @@ private function isDependantMethod(StaticCall|MethodCall|FuncCall $expr, array $
         $parentNode = $expr instanceof MethodCall ? $expr->var : $expr->class;
 
         foreach ($params as $param) {
-            SimpleCallableNodeTraverser::traverse($parentNode, function (Node $node) use ($param, &$found) {
+            SimpleCallableNodeTraverser::traverse($parentNode, function (Node $node) use ($param, &$found): ?int {
                 if ($this->nodeComparator->areNodesEqual($node, $param->var)) {
                     $found = true;
                     return NodeVisitor::STOP_TRAVERSAL;
@@ -152,7 +152,7 @@ private function isUsingThisInNonObjectContext(FuncCall|MethodCall|StaticCall $c
 
         $found = false;
 
-        SimpleCallableNodeTraverser::traverse($callLike, function (Node $node) use (&$found) {
+        SimpleCallableNodeTraverser::traverse($callLike, function (Node $node) use (&$found): ?int {
             if ($this->nodeNameResolver->isName($node, 'this')) {
                 $found = true;
                 return NodeVisitor::STOP_TRAVERSAL;

rules/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector.php

@@ -11,7 +11,6 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
-use PhpParser\Node\Param;
 use PhpParser\Node\VariadicPlaceholder;
 use Rector\CodingStyle\Guard\ArrowFunctionAndClosureFirstClassCallableGuard;
 use Rector\PHPStan\ScopeFetcher;

rules/CodingStyle/Rector/Closure/ClosureDelegatingCallToFirstClassCallableRector.php

@@ -11,7 +11,6 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
-use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\VariadicPlaceholder;
 use Rector\CodingStyle\Guard\ArrowFunctionAndClosureFirstClassCallableGuard;

rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php

@@ -8,7 +8,6 @@
 use PhpParser\Node\Expr\ArrowFunction;
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\Closure;
-use PhpParser\Node\Param;
 use Rector\CodingStyle\Rector\ArrowFunction\ArrowFunctionDelegatingCallToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\Closure\ClosureDelegatingCallToFirstClassCallableRector;
 use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;