Support Attribute in SortNamedParamRector (#7684)

* Support Attribute in SortNamedParam

* Move to source folder

Author: VincentLanglet

rules-tests/CodeQuality/Rector/FuncCall/SortNamedParamRector/Fixture/attribute.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FuncCall\SortNamedParamRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\FuncCall\SortNamedParamRector\Source\MyAttribute;
+
+#[MyAttribute(bar: 1, foo: 2)]
+#[MyAttribute(1, baz: 2, bar: 3)]
+class Test
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FuncCall\SortNamedParamRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\FuncCall\SortNamedParamRector\Source\MyAttribute;
+
+#[MyAttribute(foo: 2, bar: 1)]
+#[MyAttribute(1, bar: 3, baz: 2)]
+class Test
+{
+}
+
+?>

rules-tests/CodeQuality/Rector/FuncCall/SortNamedParamRector/Source/MyAttribute.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FuncCall\SortNamedParamRector\Source;
+
+#[\Attribute]
+class MyAttribute
+{
+    public function __construct($foo = null, $bar = null, $baz = null)
+    {
+    }
+}

rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php

@@ -6,6 +6,8 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
+use PhpParser\Node\Attribute;
+use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
@@ -62,19 +64,23 @@ function run($foo = null, $bar = null, $baz = null) {}
      */
     public function getNodeTypes(): array
     {
-        return [MethodCall::class, StaticCall::class, New_::class, FuncCall::class];
+        return [MethodCall::class, StaticCall::class, New_::class, FuncCall::class, Attribute::class];
     }
 
     /**
-     * @param MethodCall|StaticCall|New_|FuncCall $node
+     * @param MethodCall|StaticCall|New_|FuncCall|Attribute $node
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->isFirstClassCallable()) {
+        if ($node instanceof CallLike && $node->isFirstClassCallable()) {
             return null;
         }
 
-        $args = $node->getArgs();
+        if ($node instanceof Attribute) {
+            $args = $node->args;
+        } else {
+            $args = $node->getArgs();
+        }
         if (count($args) <= 1) {
             return null;
         }
@@ -85,6 +91,8 @@ public function refactor(Node $node): ?Node
 
         if ($node instanceof New_) {
             $functionLikeReflection = $this->reflectionResolver->resolveMethodReflectionFromNew($node);
+        } elseif ($node instanceof Attribute) {
+            $functionLikeReflection = $this->reflectionResolver->resolveMethodReflectionFromAttribute($node);
         } else {
             $functionLikeReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
         }

src/Reflection/ReflectionResolver.php

@@ -5,6 +5,7 @@
 namespace Rector\Reflection;
 
 use PhpParser\Node;
+use PhpParser\Node\Attribute;
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
@@ -256,6 +257,19 @@ public function resolveMethodReflectionFromNew(New_ $new): ?MethodReflection
         return $this->resolveMethodReflection($className, MethodName::CONSTRUCT, $scope);
     }
 
+    public function resolveMethodReflectionFromAttribute(Attribute $attribute): ?MethodReflection
+    {
+        $attributeClassType = $this->nodeTypeResolver->getType($attribute->name);
+        $className = ClassNameFromObjectTypeResolver::resolve($attributeClassType);
+
+        if ($className === null) {
+            return null;
+        }
+
+        $scope = $attribute->getAttribute(AttributeKey::SCOPE);
+        return $this->resolveMethodReflection($className, MethodName::CONSTRUCT, $scope);
+    }
+
     public function resolvePropertyReflectionFromPropertyFetch(
         PropertyFetch | StaticPropertyFetch $propertyFetch
     ): ?PhpPropertyReflection {