[php 8.3] cover private abstract constants in AddTypeToConstRector (#7804)

* cover private abstract constants in AddTypeToConstRector

* skip

Author: TomasVotruba

phpstan.neon

@@ -467,5 +467,12 @@ parameters:
 
         # false positive
         -
-             identifier: phpstanApi.varTagAssumption
-             path: rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php
+            identifier: phpstanApi.varTagAssumption
+            path: rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php
+
+        # bug, fix in symplify/phpstan-rules
+        -
+            identifier: symplify.noMissnamedDocTag
+            paths:
+                 - rules/Php74/NodeAnalyzer/ClosureArrowFunctionAnalyzer.php
+                 - rules/TypeDeclarationDocblocks/TypeResolver/ConstantArrayTypeGeneralizer.php

rules-tests/Php83/Rector/ClassConst/AddTypeToConstRector/Fixture/handle_private_abstract.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
+
+abstract class HandlePrivateAbstract
+{
+    private const VALUE = 1000;
+}
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
+
+abstract class HandlePrivateAbstract
+{
+    private const int VALUE = 1000;
+}
+?>

rules/Php83/Rector/ClassConst/AddTypeToConstRector.php

@@ -78,10 +78,6 @@ public function refactor(Node $node): ?Class_
             return null;
         }
 
-        if ($node->isAbstract()) {
-            return null;
-        }
-
         $classConsts = $node->getConstants();
         if ($classConsts === []) {
             return null;
@@ -99,6 +95,10 @@ public function refactor(Node $node): ?Class_
             }
 
             foreach ($classConst->consts as $constNode) {
+                if ($node->isAbstract() && ! $classConst->isPrivate()) {
+                    continue;
+                }
+
                 if ($this->isConstGuardedByParents($constNode, $parentClassReflections)) {
                     continue;
                 }