[Php85] Skip inside expression assign on ArrayFirstLastRector

Author: samsonasik

rules-tests/Php85/Rector/ArrayDimFetch/ArrayFirstLastRector/Fixture/skip_as_var_assigned.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php85\Rector\ArrayDimFetch\ArrayFirstLastRector\Fixture;
+
+final class SkipAsVarAssigned
+{
+    public function run()
+    {
+        $myArray = [
+            'test'=> ['label'=> ['show'=> false]]
+        ];
+
+        $myArray[array_key_last($myArray)]['label']['show'] = true;
+        var_dump($myArray);
+    }
+}

rules/Php85/Rector/ArrayDimFetch/ArrayFirstLastRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\FuncCall;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -82,6 +83,11 @@ public function refactor(Node $node): ?FuncCall
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($node->var);
+        if ($scope->isInExpressionAssign($node)) {
+            return null;
+        }
+
         $functionName = $this->isName($node->dim, self::ARRAY_KEY_FIRST)
             ? 'array_first'
             : 'array_last';