Fix crash ->getComments() return must be array over true on ClosureToArrowFunctionRector (#7761)

samsonasik · web-flow · commit f914c8494459 · 2025-12-18T09:18:41.000+01:00
* Fix crash -&gt;getComments() return must be array over true on ClosureToArrowFunctionRector

* final touch: mirror comment of ArrowFunction as its stmt
diff --git a/rules/Php74/Rector/Closure/ClosureToArrowFunctionRector.php b/rules/Php74/Rector/Closure/ClosureToArrowFunctionRector.php
@@ -89,7 +89,7 @@ public function refactor(Node $node): ?Node
         $comments = $node->stmts[0]->getAttribute(AttributeKey::COMMENTS) ?? [];
         if ($comments !== []) {
             $this->mirrorComments($arrowFunction->expr, $node->stmts[0]);
-            $arrowFunction->setAttribute(AttributeKey::COMMENTS, true);
+            $arrowFunction->setAttribute(AttributeKey::COMMENTS, $node->stmts[0]->getComments());
         }
 
         return $arrowFunction;

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function refactor(Node $node): ?Node`
`89`	`89`	`$comments = $node->stmts[0]->getAttribute(AttributeKey::COMMENTS) ?? [];`
`90`	`90`	`if ($comments !== []) {`
`91`	`91`	`$this->mirrorComments($arrowFunction->expr, $node->stmts[0]);`
`92`		`- $arrowFunction->setAttribute(AttributeKey::COMMENTS, true);`
	`92`	`+ $arrowFunction->setAttribute(AttributeKey::COMMENTS, $node->stmts[0]->getComments());`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`return $arrowFunction;`