From 42fa97af41bad8d93362ff9e3411e979ccb0bafe Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sat, 11 Oct 2025 10:42:14 +0200 Subject: [PATCH] cover bare getters --- .../Fixture/two_bare_getters.php.inc | 34 +++++++++++++++++++ .../Source/SomeGetter.php | 11 ++++++ ...inaryOpStandaloneAssignsToDirectRector.php | 2 +- 3 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/two_bare_getters.php.inc create mode 100644 rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Source/SomeGetter.php diff --git a/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/two_bare_getters.php.inc b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/two_bare_getters.php.inc new file mode 100644 index 00000000000..69d53d06a79 --- /dev/null +++ b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/two_bare_getters.php.inc @@ -0,0 +1,34 @@ +getSome(); + $second = $secondSomeGetter->getSome(); + + return $first <=> $second; + } +} + +?> +----- +getSome() <=> $secondSomeGetter->getSome(); + } +} + +?> diff --git a/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Source/SomeGetter.php b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Source/SomeGetter.php new file mode 100644 index 00000000000..fcc9329bcac --- /dev/null +++ b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Source/SomeGetter.php @@ -0,0 +1,11 @@ +expr instanceof MethodCall) { + if ($assign->expr instanceof MethodCall && $assign->expr->args !== []) { return null; }