diff --git a/composer.json b/composer.json index bb7399ad78b..ca495d81f38 100644 --- a/composer.json +++ b/composer.json @@ -56,7 +56,7 @@ "rector/type-perfect": "^2.1", "shipmonk/composer-dependency-analyser": "^1.8", "symplify/phpstan-extensions": "^12.0.2", - "symplify/phpstan-rules": "^14.8.4", + "symplify/phpstan-rules": "^14.8.5", "symplify/vendor-patches": "^11.5", "tomasvotruba/class-leak": "^2.0", "tracy/tracy": "^2.11" diff --git a/phpstan.neon b/phpstan.neon index 38f660b0e2e..0258b5d11d2 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -2,9 +2,6 @@ includes: - vendor/symplify/phpstan-rules/config/symplify-rules.neon - vendor/symplify/phpstan-rules/config/rector-rules.neon -rules: - - Rector\Utils\PHPStan\Rule\PreferDirectIsNameRule - parameters: level: 8 diff --git a/utils/PHPStan/Rule/PreferDirectIsNameRule.php b/utils/PHPStan/Rule/PreferDirectIsNameRule.php deleted file mode 100644 index cf9edfc0cf6..00000000000 --- a/utils/PHPStan/Rule/PreferDirectIsNameRule.php +++ /dev/null @@ -1,76 +0,0 @@ -isName() call instead of fetching NodeNameResolver service'; - - public function getNodeType(): string - { - return MethodCall::class; - } - - /** - * @param MethodCall $node - */ - public function processNode(Node $node, Scope $scope): array - { - if ($node->isFirstClassCallable()) { - return []; - } - - if (! $node->name instanceof Identifier) { - return []; - } - - if (! in_array($node->name, ['isName', 'isNames', 'getName'])) { - return []; - } - - if (! $scope->isInClass()) { - return []; - } - - $classReflection = $scope->getClassReflection(); - - // skip self - if ($classReflection->getName() === AbstractRector::class) { - return []; - } - - // check rector rules only - if (! $classReflection->is(AbstractRector::class)) { - return []; - } - - // check child Rectors only - if ($classReflection->isAbstract()) { - return []; - } - - if (! $node->var instanceof PropertyFetch) { - return []; - } - - $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE) - ->identifier('rector.preferDirectIsName') - ->build(); - - return [$identifierRuleError]; - } -}