How to make ClassPropertyAssignToConstructorPromotionRector aware of Doctrine's docblock

[ancient-spirit]

Hi, how to make ClassPropertyAssignToConstructorPromotionRector aware of Doctrine's docblock?
here the rector remove the class property (private $user;) that have Doctrine's docblock

the snippet code available on https://getrector.org/demo/1ec4f32a-9653-6448-b2fd-65d194c70ecf

12) src/Entity/ResetPasswordRequest.php:18

    ---------- begin diff ----------
@@ @@
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
      */
-    private $id;
+    private ?int $id = null;

-    /**
-     * @ORM\ManyToOne(targetEntity=Person::class)
-     * @ORM\JoinColumn(nullable=false)
-     */
-    private $user;
-
-    public function __construct(object $user, \DateTimeInterface $expiresAt, string $selector, string $hashedToken)
+    public function __construct(private object $user, \DateTimeInterface $expiresAt, string $selector, string $hashedToken)
     {
-        $this->user = $user;
         $this->initialize($expiresAt, $selector, $hashedToken);
     }
    ----------- end diff -----------

Applied rules:
 * ReplaceArgumentDefaultValueRector
 * TypedPropertyRector (https://wiki.php.net/rfc/typed_properties_v2#proposal)
 * ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotion https://github.com/php/php-src/pull/5291)
 * ArgumentRemoverRector
 * RenamePropertyRector
 * WrapReturnRector
 * AddParamTypeDeclarationRector

Thank you in advance 🙏

[TomasVotruba]

Hi, thanks for reporting. This looks like a bug.
Could you add test fixture to ClassPropertyAssignToConstructorPromotionRectorTest?

[ancient-spirit]

on my project, it seems the installed version is 0.12.12

PS C:\workspace\php\datakawa> composer info rector/rector
name     : rector/rector
descrip. : Prefixed and PHP 7.1 downgraded version of rector/rector
keywords :
versions : * 0.12.12
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage :
source   : [git] https://github.com/rectorphp/rector.git efcc6f135a76bfd031c31fc182ce7a6fd02b3ce5
dist     : [zip] https://api.github.com/repos/rectorphp/rector/zipball/efcc6f135a76bfd031c31fc182ce7a6fd02b3ce5 efcc6f135a76bfd031c31fc182ce7a6fd02b3ce5
path     : C:\workspace\php\datakawa\vendor\rector\rector
names    : rector/rector

support
issues : https://github.com/rectorphp/rector/issues
source : https://github.com/rectorphp/rector/tree/0.12.12

autoload
files

requires
php ^7.1|^8.0
phpstan/phpstan ^1.3

conflicts
phpstan/phpdoc-parser <1.2
rector/rector-cakephp *
rector/rector-doctrine *
rector/rector-laravel *
rector/rector-nette *
rector/rector-phpoffice *
rector/rector-phpunit *
rector/rector-prefixed *
rector/rector-symfony *

and my fork is

PS C:\workspace\git\rector-src> git rev-parse --short HEAD
e27e48309

[ancient-spirit]

well, I found out that this setting is the source of strange behavior.

    $parameters->set(\Rector\Core\Configuration\Option::AUTO_IMPORT_NAMES, true);

by commenting this option, I got same result between the /Fixture and my project.

Is this probably bug?

[TomasVotruba]

Great! We're getting closer.

Probably is. That's why we need to failing test fixture to be able to solve the root.

Could you add test Fixture and test class with this exact setup?

[ancient-spirit]

I'm not sure how to create Fixture for Option's constant.

I can confirm the result by using getrector.org/demo

• ✅ OK https://getrector.org/demo/1ec7229c-4eab-6fb6-acff-4f4c3aa10000
• ❌ KO https://getrector.org/demo/1ec7229b-4673-652a-b36f-7f3ea4f80b95

[TomasVotruba]

You can copy another issue report test and only replace config with your values:
https://github.com/rectorphp/rector-src/tree/main/tests/Issues/Issue6840