[downgrade] Avoid skip `$node->isFirstClassCallable()` check when possible on DowngradePhp82+ on function downgrade, avoid function not downgraded

[samsonasik]

When we downgrade, but on target php 8.1+, first class callable feature is already exists.

Function replacement usage should use code snippets, like in:

https://github.com/rectorphp/rector-downgrade-php/blob/73e0dbb5437d07df74b01773c6db92720fe485a9/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php#L148

then remove the firstClassCallable() check to avoid function not exists on downgraded code.

Because first class callable is available on php 8.1+, so skip isFirstClassCallable() will cause invalid change when code available to be downgraded.

see https://3v4l.org/6sLa4

to avoid error on first class callable, the args should be used instead:

-$args = $node->getArgs();
+$args = $node->args;

[samsonasik]

part 1:

• [DowngradePhp83] Allow with first class callable on DowngradeJsonValidateRector rector-downgrade-php#332

[TomasVotruba]

Does this need any further work? If so, could you provide failing sample, so we know what needs to be fixed.

[samsonasik]

Yes, eg: on php 8.5 downgrade rules:

https://github.com/rectorphp/rector-downgrade-php/tree/388ab1f6e7ccbef44a9a2e853361de0095d01c02/rules/DowngradePhp84/Rector/Expression

that need to use StmtsAwareInterface and friend, then uses snippet code over change logic, like this one:

https://github.com/rectorphp/rector-downgrade-php/blob/73e0dbb5437d07df74b01773c6db92720fe485a9/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php#L148

Just don't have a chance right now due to other priorities, feel free to close and i will come to it later.

[TomasVotruba]

Thanks for the work. Okay, let's revisit on exact bugs later, if they come :)