NarrowObjectReturnTypeRector replaces interface with implementing concrete class

[WyriHaximus]

Bug Report

Subject	Details
Rector version	e.g. v2.2.10 (invoke vendor/bin/rector --version)

Minimal PHP Code Causing Issue

https://getrector.com/demo/c43e917d-7f01-44c0-b43f-426f51ec938c

Expected Behaviour

No changes in the return type of Vhost\Healthz::handle. My expectation here was that Rector would respect the return type and anyone call that method should care about how I get to my return value, only that it implements that interface.

P.S. Not sure how much of this relates to #9489

[samsonasik]

This is expected, the purpose is clear to get exact type when possible. You can skip the rule if needed

https://getrector.com/documentation/ignoring-rules-or-paths

[WyriHaximus]

This is expected, the purpose is clear to get exact type when possible.

This honestly wasn't expected, for the example on https://getrector.com/rule-detail/narrow-object-return-type-rector I get it, but a class implementing the interface you have as return type, no.

You can skip the rule if needed
https://getrector.com/documentation/ignoring-rules-or-paths

Yeah I'm aware of that and will do that assuming this behavior won't be fixed, would have been nice if that could be done like PHPStan does with:

/** @rectorphp-ignore NarrowObjectReturnTypeRector */

[TomasVotruba]

I agree with @WyriHaximus . I think we'll have to skip such cases, as it's not first time this was reported.
It makes sense for implemented method, where it narrows the type. Here it would only override existing declared type.

[samsonasik]

@TomasVotruba how about make it configurable? eg: allow_interface_to_exact_type, default to true?

[WyriHaximus]

@samsonasik Or make it a list of configurable interfaces?

[samsonasik]

That also can be an option 👍

[TomasVotruba]

@TomasVotruba how about make it configurable? eg: allow_interface_to_exact_type, default to true?

I'd prefer to exclude the case above, as its out of scope of this rule. There must be some parent method (interface or class) we override, so the narrow type in the rule name happens.

[samsonasik]

I think interface with Psr\\ prefix can be skipped then

[TomasVotruba]

@samsonasik No parent class/interface → skip 👍

[samsonasik]

no parent class can be JsonResponse -> Response -> ResponseInterface, while user may return:

public function indexAction(): Response
{
    return new JsonResponse();
}

which Response can be JsonResponse instead, that both Response and JsonResponse are instantiable.

[samsonasik]

I check the fixtures and the origin PR about this, there are valid arguments which interface/abstract should be allowed, I think configurable should be the way, it can be true or false, but make it configurable is better imo.

I will create a PR for it so it can be usefull, while allow user to configure it.

[samsonasik]

I created PR to make it configurable, imo, based on the long discussion we had in the original PR, this still valid, but make it configurable so user can choose the design they want:

• [TypeDeclaration] Make configurable on NarrowObjectReturnTypeRector to allow to not make change return on abstract/interface return rector-src#7695