Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve annotation when recreating the SC #2890

Open
Madhu-1 opened this issue Nov 12, 2024 · 1 comment
Open

Preserve annotation when recreating the SC #2890

Madhu-1 opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 12, 2024

          I would recreate the SC in line 232 with the annotations and labels already present. The labels are also important.

If the reconcile fails to update the SC annotations in this line, a future reconcile will not have the copy of the existing annotations etc. and hence this will never be set on the recreated SC.

Originally posted by @ShyamsundarR in #2817 (comment)

@black-dragon74
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants