adding tests and logic #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimonsh
force-pushed
the
poll_suggestion_logic
branch
from
684a39d to
7c1b6ac
Compare
|
You can try to make them both offset naive : |
rimonsh
force-pushed
the
poll_suggestion_logic
branch
from
878eb9b to
7d9d04a
Compare
kobihk
requested changes
May 18, 2023
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
rimonsh
force-pushed
the
poll_suggestion_logic
branch
from
7d9d04a to
98c7574
Compare
rotem2022
reviewed
Jun 1, 2023
There was a problem hiding this comment.
maybe consider to add a field that tracks the number of votes each suggestion receives. This addition can provide valuable data for evaluating the popularity for each suggestion. Or you thought of alternative way for determining the chosen suggestion?
SaarOrus
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
This PR I tested Poll suggestion Saving to django DB, whether it's in the past , or there's already a suggestion in the same time.
Notes for reviewer
I would be more than happy to hear more suggestions on how to check if suggested time is in the past (less than datetime.now() ).
For some reason, the line "if self.time < timezone.now():" is not passing.
Related Issue
Resolves #103
Test coverage
-Testing suggested time is not in the past.
-Testing that there's no other suggestion like it in the same poll.