What happened
PR #3202 removed the stale plugins/dynamic-home-page: entry from workspaces/homepage/plugins-list.yaml, completing a rename to plugins/homepage that started in PR #2644. The review agent (workflow run 31201381924) identified during its analysis that dynamic-home-page is still referenced in two scorecard E2E config files, but this finding was never posted because the PR was merged before the review completed. The scorecard workspace was subsequently upgraded in PR #3101 without cleaning up these references.
What could go better
The scorecard E2E test configs at workspaces/scorecard/e2e-tests/tests/config/dynamic-plugins.yaml (lines 133-154) and workspaces/scorecard/e2e-tests/tests/config/filecheck/dynamic-plugins.yaml (lines 59-80) still reference dynamic-home-page with OCI tag bs_1.49.4__1.13.1. These are the only two files in the entire repository that still reference the old plugin name. Currently this works because the old OCI image is still published and accessible, but if that image is removed or the scorecard tests are updated to use a newer Backstage version, these references will break nightly E2E runs. Confidence is high that these are stale references — there is no metadata YAML or plugins-list entry for dynamic-home-page anywhere in the repo.
Proposed change
Update the two scorecard E2E config files to reference the renamed homepage plugin instead of dynamic-home-page. In workspaces/scorecard/e2e-tests/tests/config/dynamic-plugins.yaml and workspaces/scorecard/e2e-tests/tests/config/filecheck/dynamic-plugins.yaml, replace the dynamic-home-page package name and OCI reference with the corresponding homepage package name and current OCI tag from workspaces/homepage/metadata/. The scorecard tests use this plugin to provide the home.page/cards mount point where scorecard homepage cards are rendered, so the replacement plugin must serve the same mount point.
Validation criteria
After the update: (1) grep -r 'dynamic-home-page' workspaces/scorecard/ returns zero results, (2) scorecard E2E nightly tests pass with the updated plugin reference (verifiable via the next nightly run or /test e2e-tests PR command), (3) the scorecard homepage cards still render correctly in the E2E test assertions.
Generated by retro agent from #3202
What happened
PR #3202 removed the stale
plugins/dynamic-home-page:entry fromworkspaces/homepage/plugins-list.yaml, completing a rename toplugins/homepagethat started in PR #2644. The review agent (workflow run 31201381924) identified during its analysis thatdynamic-home-pageis still referenced in two scorecard E2E config files, but this finding was never posted because the PR was merged before the review completed. The scorecard workspace was subsequently upgraded in PR #3101 without cleaning up these references.What could go better
The scorecard E2E test configs at
workspaces/scorecard/e2e-tests/tests/config/dynamic-plugins.yaml(lines 133-154) andworkspaces/scorecard/e2e-tests/tests/config/filecheck/dynamic-plugins.yaml(lines 59-80) still referencedynamic-home-pagewith OCI tagbs_1.49.4__1.13.1. These are the only two files in the entire repository that still reference the old plugin name. Currently this works because the old OCI image is still published and accessible, but if that image is removed or the scorecard tests are updated to use a newer Backstage version, these references will break nightly E2E runs. Confidence is high that these are stale references — there is no metadata YAML or plugins-list entry fordynamic-home-pageanywhere in the repo.Proposed change
Update the two scorecard E2E config files to reference the renamed
homepageplugin instead ofdynamic-home-page. Inworkspaces/scorecard/e2e-tests/tests/config/dynamic-plugins.yamlandworkspaces/scorecard/e2e-tests/tests/config/filecheck/dynamic-plugins.yaml, replace thedynamic-home-pagepackage name and OCI reference with the correspondinghomepagepackage name and current OCI tag fromworkspaces/homepage/metadata/. The scorecard tests use this plugin to provide thehome.page/cardsmount point where scorecard homepage cards are rendered, so the replacement plugin must serve the same mount point.Validation criteria
After the update: (1)
grep -r 'dynamic-home-page' workspaces/scorecard/returns zero results, (2) scorecard E2E nightly tests pass with the updated plugin reference (verifiable via the next nightly run or/test e2e-testsPR command), (3) the scorecard homepage cards still render correctly in the E2E test assertions.Generated by retro agent from #3202