chore(e2e): migrate gitlab auth provider tests - #3207
Conversation
|
🤖 Review · Commit: |
d20df39 to
0b02ddf
Compare
|
/publish |
|
🤖 Finished Review · ✅ Success · Started 7:27 PM UTC · Completed 7:33 PM UTC Commit: |
Review — approveClean migration of GitLab auth provider E2E tests from RHDH core into the What was reviewed
ObservationsOAuth app lifecycle on worker restart (low) — The OAuth app creation in Duplicated catalog helpers (low) — Neither observation is blocking — the tests are correct and ready to merge. Previous runReviewFindingsMedium
Low
Previous run (2)ReviewFindingsMedium
Low
Previous run (3)Review — chore(e2e): migrate gitlab auth provider testsVerdict: approve SummaryThis PR migrates GitLab auth provider E2E tests from RHDH core into the The implementation closely follows the established Reviewed dimensions
Design observations (non-blocking)OAuth app lifecycle on worker restart: On worker restart, Shared helper functions:
Previous run (4)ReviewFindingsMedium
Low
Previous run (5)ReviewFindingsLow
Previous run (6)Review — approvePR: #3207 — chore(e2e): migrate gitlab auth provider tests SummaryThis PR migrates GitLab auth provider E2E tests from RHDH core into the backstage workspace. It adds a new Playwright project ( Changes reviewed
Correctness assessment
Security assessment
Conventions assessment
No findings above the severity threshold. Previous run (7)Review — approveWell-structured migration of GitLab auth provider E2E tests from RHDH core into the backstage workspace. The test code follows existing patterns, config files use the established VAULT_* secret injection conventions, and the OAuth app lifecycle (create/cleanup) is properly managed. One low-severity improvement noted below. Findings[low] Missing The Other specs in this workspace that perform similar pre-deploy setup already use
Wrapping the OAuth app creation + configure + deploy in Checked dimensions
Previous run (8)Review — approvePR: #3207 — chore(e2e): migrate gitlab auth provider tests SummaryThis PR migrates GitLab auth provider E2E tests from RHDH core into the What the PR adds:
Dimension Assessment
Findings[low · correctness] If a test fails and Playwright kills the worker, The risk is contained — apps are named with Remediation (optional follow-up): Consider adding a prefix-based cleanup sweep in Previous run (9)ReviewVerdict: approve Clean migration of GitLab auth provider E2E tests from RHDH core into the What was reviewed
Highlights
Observations (non-blocking)
Labels: PR adds new E2E tests to the backstage workspace |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
|
Great work! |
|
/test e2e-ocp-helm |
|
🤖 Review · Commit: |
959f1fb to
be25bd9
Compare
|
🤖 Finished Review · ✅ Success · Started 9:04 PM UTC · Completed 9:11 PM UTC Commit: |
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
|
/test e2e-ocp-helm |
|
🤖 Finished Review · ✅ Success · Started 6:49 PM UTC · Completed 6:54 PM UTC Commit: |
|
Publish workflow has completed with failure. Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
|
/retest |
|
🤖 Finished Review · ✅ Success · Started 6:07 PM UTC · Completed 6:22 PM UTC Commit: |
8442bad to
ee9007d
Compare
|
🤖 Review · ❌ Terminated · Started 7:46 PM UTC · Ended 8:01 PM UTC Commit: |
|
/test e2e-ocp-helm |
|
🤖 Finished Review · ✅ Success · Started 7:46 PM UTC · Completed 8:01 PM UTC Commit: |
Signed-off-by: Jessica He <jhe@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ee9007d to
f0f5b93
Compare
|
|
🤖 Finished Review · ✅ Success · Started 8:45 PM UTC · Completed 8:52 PM UTC Commit: |
|
|
||
| if (oauthAppId !== null) { | ||
| await oauthHelper.deleteOAuthApplication(oauthAppId); | ||
| oauthAppId = null; |
There was a problem hiding this comment.
[low] correctness
OAuth app creation runs outside test.runOnce(), so on worker restart a new app is created but deploy() (internally guarded by runOnce) skips — leaving stale OAuth credentials in the cluster. Serial mode mitigates this in practice, but the lifecycle is less resilient than the Microsoft auth test's idempotent pattern.
Suggested fix: Consider wrapping the entire OAuth app creation + deploy sequence inside test.runOnce(), or moving the OAuth app creation into a separate helper that checks for an existing app before creating a new one.
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
|
@JessicaJHee: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Summary
backstage-gitlab-authcovering sign-in resolvers, and GitLab user/group ingestion against self-hosted GitLab orgFixes RHIDP-14481