From code review of PR #15.
GenerateKubeYAML and GeneratePodmanVolumes in pkg/collection/collection.go take io.Writer but call fmt.Fprintf without checking the returned error. As library functions, they should return error so callers can handle write failures.
Current: func GenerateKubeYAML(w io.Writer, col *SkillCollection, mountRoot string)
Proposed: func GenerateKubeYAML(w io.Writer, col *SkillCollection, mountRoot string) error
Low risk since CLI callers write to stdout, but correct for library consumers.
From code review of PR #15.
GenerateKubeYAMLandGeneratePodmanVolumesinpkg/collection/collection.gotakeio.Writerbut callfmt.Fprintfwithout checking the returned error. As library functions, they should returnerrorso callers can handle write failures.Current:
func GenerateKubeYAML(w io.Writer, col *SkillCollection, mountRoot string)Proposed:
func GenerateKubeYAML(w io.Writer, col *SkillCollection, mountRoot string) errorLow risk since CLI callers write to stdout, but correct for library consumers.