use setpriv instead of gosu #402
Conversation
|
for #401 |
|
This is the minimal PR which didn't run apply.sh. Please comment if you'd prefer that I run it to update the dockerfiles. |
There was a problem hiding this comment.
I've left a few minor suggestions, but overall seems fine to me for this case (where we don't need to maintain gosu or a compatible interface for downstream image user compatibility).
This is the minimal PR which didn't run apply.sh. Please comment if you'd prefer that I run it to update the dockerfiles.
Yes, please also run apply-templates.sh.
|
Thank you for the prompt feedback. |
|
Bumping this. I've built this image and scanned it with trivy Looks great! Much better than any other redis image i've scanned with alpine or debian |
There was a problem hiding this comment.
I agree with this change and would have approved it sooner but didn't want to speak for the new maintainers. We were in the process of getting this repo transferred under the control of upstream Redis which is why this is now under https://github.com/redis/docker-library-redis.
So, while I approve of this, the new maintainers from Redis are now the decision makers and they are welcome to accept or reject this change.
|
I'd really appreciate it if this could be merged 🙂 Cheers |
|
+1 for this ;) |
|
love to see this 👍 |
Closes #390
Closes #401