Skip to content

Conversation

@cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Nov 7, 2025

Need to clear the openapi.json file before merging.

@cmilesb cmilesb requested review from a team and yharesh November 7, 2025 16:40
@cmilesb cmilesb self-assigned this Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

DOC-5767

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yharesh
Copy link

yharesh commented Nov 9, 2025

Missing some information related to FOCUS, for example, the list of fields FOCUS is providing (even 1 sentence and then add the link to the focus library fields (https://focus.finops.org/focus-columns/).
I will send you some additional information, highlighting key details related to this matter.

@yharesh
Copy link

yharesh commented Nov 11, 2025

  1. in the 1st example in the Generate cost report section, can you
    Please change the date range in this example to
    startDate 2025-01-01
    endDate 2025-01-31
    We will provide you with more information from the code (e.g, certain restrictions, permissions etc.) so you will be able to add it to the documents (for example the cost report date range cant be more than 40 days) we will send you soon.
Screenshot 2025-11-11 at 12 49 15 2. image in the Format line **The default format should be CSV and not json please correct** 3. We are going live with it on December 7th, so maybe you want to change the change log document to match.

Copy link

@ramiloif ramiloif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added detailed line-by-line comments based on the actual API implementation code. The main gaps are:

  1. Request body structure and parameters
  2. Validation rules (40-day limit, date format, etc.)
  3. Authentication/permission requirements
  4. Error responses documentation
  5. Beta API notice
  6. Response structure examples

Happy to provide more specific examples or clarifications for any of these!

"servers": [
{
"url": "https://api.redislabs.com/v1"
"url": "https://capi.k8s-billing-dev.sm-qa.qa.redislabs.com/v1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://capi.k8s-billing-dev.sm-qa.qa.redislabs.com/v1
This is the QA environment URL.
We shall stick with https://api.redislabs.com/v1

Copy link

@ramiloif ramiloif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 6 focused comments identifying missing validation rules, error codes, and constraints from the implementation. Key items:

  • 40-day maximum date range validation
  • All 8 error codes with descriptions
  • Beta status and permission requirements
  • Tag validation rules
  • HTTP 202 status clarification

All based on the actual API implementation code.

```json
{
"startDate": "2025-01-01",
"endDate": "2025-12-31"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: Date range validation rules.

The implementation enforces a 40-day maximum date range. This should be documented here.

Suggested addition:

### Date range requirements

- Dates must be in `YYYY-MM-DD` format
- End date must be **after** start date (not equal)
- Maximum date range: **40 days**


You can use the Redis Cloud REST API to generate and download a cost report in a [FinOps Open Cost and Usage Specification (FOCUS)](https://focus.finops.org/) compatible format. The report includes detailed information about your Redis Cloud subscription usage and associated charges.

{{< embed-md "rc-cost-report-api.md" >}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: Beta status and permission requirements.

Should add a note here:

{{< note >}}
- This is a **beta API** - contact Redis Cloud Support to opt in
- Requires **OWNER** or **VIEWER** permission
{{< /note >}}

| `subscriptionIds` | Array of integers | Filters the report to only include the specified subscriptions. |
| `databaseIds` | Array of integers | Filters the report to only include the specified databases. |
| `subscriptionType` | Enum: `essentials`, `pro` | Filters the report to only include subscriptions of the specified type. |
| `regions` | Array of strings | Filters the report to only include subscriptions in the specified regions. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: Tag validation rules.

Should note that for tags:

  • Both key and value are required
  • Neither can be empty or null
  • Will return error codes if invalid (COST_REPORT_TAG_KEY_EMPTY or COST_REPORT_TAG_VALUE_EMPTY)

@@ -0,0 +1,7 @@
To get the cost report using the REST API:

1. Use [`POST /cost-report`]({{< relref "/operate/rc/api/api-reference#tag/Account/operation/createCostReport" >}}) to generate a cost report, with the request body containing the `startDate` and `endDate` for the report as well as any optional filters. The response includes a `taskId` that you can use to track the status of the report generation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: This embedded section should mention key constraints:

  • Date range limited to 40 days maximum
  • Both endpoints require OWNER or VIEWER permission
  • This is a beta API (contact support to opt in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants