Feature Request: ability to provide a logger as an Options setting

[ccoVeille]

Right now, the logger is global to the module.

This could help to solve things like this:

• we may want a VoidLogger for one client, or for the sentinel client but not the others
• provide better context error with each client, for example when code handles connections to multiple Redis instances
• it can be challenging when dealing with unit tests.

Here this issue is here to get feedback about the idea.

I feel like a client option for the logger of the NewClient, NewSentinel and NewDialer seems an easy way to provide this
https://pkg.go.dev/github.com/redis/go-redis/v9#Options

Then we would fall back on the global logger.

I can implement this if you are fine with the idea.

[ndyakov]

Hello @ccoVeille , we were thinking about adding a more configurable logger in v10 because it would break the current logging. Your suggestion to use the global logger IF a local one is not specified makes sense and may enable us to ship this even in v9.x. Feel free to take a shot at it!

[ccoVeille]

Great then, I will code it when I will have a computer with me, maybe next week.

Feel free to assign it to me.

Is there an issue I can follow about the v10 logger ? or is it just an idea/plan ?

Thanks

[ndyakov]

@ccoVeille it's just one of the topics we marked as tech dept that should be addressed, I do have some ideas, maybe we can work on putting them in writing.

The logger:

• should be able to support different log levels
• should be able to print structured log messages, at the moment I used json for https://github.com/redis/go-redis/blob/master/internal/maintnotifications/logs/log_messages.go , you can take a look at it
• in the future, we may want to integrate https://opentelemetry.io/docs/specs/otel/logs/ , so this should be doable
• for the tests, it is useful to be able to filter given logs by pattern (blacklist or whitelist)

[ccoVeille]

This would go beyond what I thought, but why not.

I feel like logger could be a slog.Handler

https://github.com/golang/example/blob/master/slog-handler-guide/README.md

I could provide a logger like this, and refactoring everything and make it retro compatible. But the scope would be wider than I wanted to work on.