fix vsim_withscores

Author: nkaradzhov

packages/client/lib/commands/VSIM.spec.ts

@@ -49,4 +49,30 @@ describe('VSIM', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vSim with RESP3', async client => {
+    await client.vAdd('resp3-key', [1.0, 2.0, 3.0], 'element1');
+    await client.vAdd('resp3-key', [1.1, 2.1, 3.1], 'element2');
+    await client.vAdd('resp3-key', [2.0, 3.0, 4.0], 'element3');
+
+    // Test similarity search with vector
+    const resultWithVector = await client.vSim('resp3-key', [1.05, 2.05, 3.05]);
+    assert.ok(Array.isArray(resultWithVector));
+    assert.ok(resultWithVector.length > 0);
+
+    // Test similarity search with element
+    const resultWithElement = await client.vSim('resp3-key', 'element1');
+    assert.ok(Array.isArray(resultWithElement));
+    assert.ok(resultWithElement.includes('element1'));
+
+    // Test with options
+    const resultWithOptions = await client.vSim('resp3-key', 'element1', { COUNT: 2 });
+    assert.ok(Array.isArray(resultWithOptions));
+    assert.ok(resultWithOptions.length <= 2);
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VSIM_WITHSCORES.spec.ts

@@ -5,23 +5,55 @@ import { parseArgs } from './generic-transformers';
 
 describe('VSIM WITHSCORES', () => {
   it('transformArguments', () => {
-    assert.deepEqual(
-      parseArgs(VSIM_WITHSCORES, 'key', 'element'),
-      ['VSIM', 'key', 'ELE', 'element', 'WITHSCORES']
-    );
+    assert.deepEqual(parseArgs(VSIM_WITHSCORES, 'key', 'element'), [
+      'VSIM',
+      'key',
+      'ELE',
+      'element',
+      'WITHSCORES'
+    ]);
   });
 
-  testUtils.testAll('vSimWithScores', async client => {
-    await client.vAdd('key', [1.0, 2.0, 3.0], 'element1');
-    await client.vAdd('key', [1.1, 2.1, 3.1], 'element2');
+  testUtils.testAll(
+    'vSimWithScores',
+    async client => {
+      await client.vAdd('key', [1.0, 2.0, 3.0], 'element1');
+      await client.vAdd('key', [1.1, 2.1, 3.1], 'element2');
 
-    const result = await client.vSimWithScores('key', 'element1');
-    assert.ok(Array.isArray(result));
-    assert.ok(result.length > 0);
-    assert.ok(typeof result[0] === 'object');
-    assert.ok('value' in result[0] && 'score' in result[0]);
-  }, {
-    client: GLOBAL.SERVERS.OPEN,
-    cluster: GLOBAL.CLUSTERS.OPEN
-  });
+      const result = await client.vSimWithScores('key', 'element1');
+
+      assert.ok(typeof result === 'object');
+      assert.ok('element1' in result);
+      assert.ok('element2' in result);
+      assert.equal(typeof result['element1'], 'number');
+      assert.equal(typeof result['element2'], 'number');
+    },
+    {
+      client: GLOBAL.SERVERS.OPEN,
+      cluster: GLOBAL.CLUSTERS.OPEN
+    }
+  );
+
+  testUtils.testWithClient(
+    'vSimWithScores with RESP3 - returns Map with scores',
+    async client => {
+      await client.vAdd('resp3-key', [1.0, 2.0, 3.0], 'element1');
+      await client.vAdd('resp3-key', [1.1, 2.1, 3.1], 'element2');
+      await client.vAdd('resp3-key', [2.0, 3.0, 4.0], 'element3');
+
+      const result = await client.vSimWithScores('resp3-key', 'element1');
+
+      assert.ok(typeof result === 'object');
+      assert.ok('element1' in result);
+      assert.ok('element2' in result);
+      assert.equal(typeof result['element1'], 'number');
+      assert.equal(typeof result['element2'], 'number');
+    },
+    {
+      ...GLOBAL.SERVERS.OPEN,
+      clientOptions: {
+        RESP: 3
+      }
+    }
+  );
 });

packages/client/lib/commands/VSIM_WITHSCORES.ts

@@ -1,9 +1,16 @@
-import { Command } from '../RESP/types';
-import { transformSortedSetReply } from './generic-transformers';
+import {
+  ArrayReply,
+  BlobStringReply,
+  Command,
+  DoubleReply,
+  MapReply,
+  TuplesReply,
+  UnwrapReply
+} from '../RESP/types';
+import { transformDoubleReply } from './generic-transformers';
 import VSIM from './VSIM';
 
 export default {
-  CACHEABLE: VSIM.CACHEABLE,
   IS_READ_ONLY: VSIM.IS_READ_ONLY,
   /**
    * Retrieve elements similar to a given vector or element with similarity scores
@@ -16,5 +23,15 @@ export default {
     VSIM.parseCommand(...args);
     parser.push('WITHSCORES');
   },
-  transformReply: transformSortedSetReply
+  transformReply: {
+    2: (reply: ArrayReply<BlobStringReply>) => {
+      const inferred = reply as unknown as UnwrapReply<typeof reply>;
+      const members: Record<string, DoubleReply> = {};
+      for (let i = 0; i < inferred.length; i += 2) {
+        members[inferred[i].toString()] = transformDoubleReply[2](inferred[i + 1]);
+      }
+      return members;
+    },
+    3: undefined as unknown as () => MapReply<BlobStringReply, DoubleReply>
+  }
 } as const satisfies Command;