Add support for spread operator in hSet (migration issue from v3)

[MatanYemini]

Hi,

It would be nice to add support for hSet with spread operator on field -> value pairs.

In v3 it worked like charm, so we need either to include this in the migration guide/support this.

Thanks!
-m

[Frank-from-JITbase]

I'm currently having an issue where hSet is only saving 1 field-value pair. The documentation states that hmSet is deprecated and that hSet can be used with multiple field-value pairs, however in my code I have the following:

await hSet(key, 'field1', 'value1', 'field2', 'value2')
console.log(await redis.hGetAll('myKey')) // { field1: 'value1' }

If the spread operator is not working then I assume it is for the same reason?

[leibale]

These are the 4 ways to use HSET:

await client.hSet('key', 'field', 'value');
await client.hSet('key', ['1', '11', '2', '22']);
await client.hSet(['key', ['1', '11'], ['2', '22']]);
await client.hSet({
  1: '11',
  2: '22'
});

spread is not supported so if at some point there will be a new optional argument we'll be able to add it at the end... I'm actually not sure what to do here... opinions? @guyroyse @simonprickett

[guyroyse]

I'm not sure we can actually overload this in JavaScript to make it work. Seems like a great idea but this might not be possible. The easiest thing to do would be to update the migration guide as @Frank-from-JITbase suggests. But perhaps there are folks smarter than me who can see a way to solve this?

[Frank-from-JITbase]

I'm not sure we can actually overload this in JavaScript to make it work. Seems like a great idea but this might not be possible. The easiest thing to do would be to update the migration guide as @Frank-from-JITbase suggests. But perhaps there are folks smarter than me who can see a way to solve this?

I think the issue is more that it is not documented. In redis CLI you can call hSet using a series of field-value pairs but I couldn't find any documentation on how to send multiple parameters to the node module implementation of the function. If it wasn't for @leibale reply I never would have known all the different ways to call that function.

[leibale]

@Frank-from-JITbase

1. If you are using a modern IDE (such as VS Code, WebStorm, ...), you can totally trust the autocomplete as it uses the built-in TS declarations.

2. You can use the autogenerate types docs by clicking the red "documentation" button in the modules table in the main README (for example, HSET.transfromArguments type ).

3. We definitely need to improve our docs + make the autogenerated one more accessible.