-
Notifications
You must be signed in to change notification settings - Fork 53
Migrate from poetry to uv #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e7471e
to
c19c0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
- Pulled local uv sync worked for me
- Make additions worked
- Pre-commit also working for local commit
- Generally faster seems like an improvement
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements here
Makefile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same some nice adds
- name: Install Poetry | ||
uses: snok/install-poetry@v1 | ||
- name: Install uv | ||
uses: astral-sh/setup-uv@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to do this right now, but Astral publishes Docker images with uv already installed in the image, and they're Python version specific, so we could use those as a base image for every test we've tested in the matrix, assuming they have a base image for that version. And that would probably cut down a lot of install time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look and just give it a try :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into a few issues. Going to create a ticket.
Beyond poetry dependency resolution being the bane of my existence...
uv
is just better. Faster, stronger..This PR introduces
uv
as our new package manager and greatly improves the economics of our testing CI workflow on a few fronts: