Skip to content

Wrong default parameter in function 'wct_significance' #52

@yetanotherfrancisdeveloper

Description

I think there is an error for the parameter 'wavelet' in the function 'wct_significance'. The docstring says it should be an instance of a class, but a string is given.

Function's parameter:

wavelet='morlet', mc_count=300, progress=True,

Docstring:

wavelet : instance of a wavelet class, optional

Edit: I should add that the function '_check_parameter_wavelet' is not used in 'wct_significance'. If one were to use this function with the default parameter, they would get an error. In fact, in the function 'cwt', the function '_check_parameter_wavelet' is used before using 'wct_significance'.

wavelet = _check_parameter_wavelet(wavelet)

sig = wct_significance(a1, a2, dt=dt, dj=dj, s0=s0, J=J,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions