Skip to content

Commit 5d1e12a

Browse files
donavonbrophdawg11
andauthored
remove socket listeners on “abort” (#29)
Co-authored-by: Matt Brophy <[email protected]>
1 parent 3e4d588 commit 5d1e12a

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.changeset/grumpy-steaks-hug.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@remix-run/web-fetch": patch
3+
---
4+
5+
Remove socket listeners if request is aborted

packages/fetch/src/fetch.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,13 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
364364
socket.prependListener('close', onSocketClose);
365365
socket.on('data', onData);
366366

367-
request.on('close', () => {
367+
const removeSocketListeners = () => {
368368
socket.removeListener('close', onSocketClose);
369369
socket.removeListener('data', onData);
370-
});
370+
}
371+
372+
request.on('close', removeSocketListeners);
373+
request.on('abort', removeSocketListeners);
371374
});
372375
}
373376

0 commit comments

Comments
 (0)