Parsing gitea status checks is wrong #33531

dh-harald · 2025-01-11T11:58:19Z

dh-harald
Jan 11, 2025

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

I'm using renovatebot in Gitea, and using the latest version (atm): 39.103.0

Please tell us more about your question or problem

I've disabled the platform automerge as it fails sometimes, now I've problem with the renovebot automerger.
Sometimes, it just not merged the commits even if all the checks are skipped/green. Based on logs, it's complaining about the commit status
If I'm getting the status from the api, i've got the following:

$ curl -H 'Content-Type: application/json' https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1 | jq '.[] | select(.target_url
 | endswith("/1"))'
{
  "id": 47,
  "status": "pending",
  "target_url": "/k8s/manifests/actions/runs/47/jobs/1",
  "description": "Has started running",
  "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "context": "testing / test (0000_crd) (pull_request)",
  "creator": null,
  "created_at": "2025-01-10T18:31:13Z",
  "updated_at": "2025-01-10T18:31:13Z"
}
{
  "id": 48,
  "status": "success",
  "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
  "description": "Has been skipped",
  "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "context": "testing / test (0000_crd) (pull_request)",
  "creator": null,
  "created_at": "2025-01-10T18:31:13Z",
  "updated_at": "2025-01-10T18:31:13Z"
}
{
  "id": 30,
  "status": "success",
  "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
  "description": "Has been skipped",
  "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "context": "testing / test (0000_crd) (pull_request)",
  "creator": null,
  "created_at": "2025-01-10T18:29:07Z",
  "updated_at": "2025-01-10T18:29:07Z"
}
{
  "id": 2,
  "status": "pending",
  "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
  "description": "Blocked by required conditions",
  "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "context": "testing / test (0000_crd) (pull_request)",
  "creator": null,
  "created_at": "2025-01-10T18:27:53Z",
  "updated_at": "2025-01-10T18:27:53Z"
}

while the https://demo.gitea.com/api/swagger#/repository/repoGetCombinedStatusByRef endpoint responses right:

curl -k -H 'Content-Type: application/json' 'https://gitea.self.hosted/api/v1/repos/k8s/manifests/commits/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1/status' | jq .
{
  "state": "success",
  "sha": "4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "total_count": 19,
  "statuses": [
[...] 
   {
      "id": 48,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0000_crd) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:13Z",
      "updated_at": "2025-01-10T18:31:13Z"
    },
 [...]

If you see at the logs, it's setting the worstStatus to pending, and it's not merging the PR.
Is there any settings to exclude pending state, or is it a bug?

Logs (if relevant)

Logs

This is the log snippet from renovate log, where it's getting the statuses of the specific step

       "ccs": {
         "worstStatus": "pending",

Answered by rarkins

Jan 14, 2025

Converted to issue: #33613

View full answer

rarkins · 2025-01-11T12:07:24Z

rarkins
Jan 11, 2025
Maintainer

Automerging when tests are pending is not a good idea.

23 replies

viceice Jan 11, 2025
Maintainer

doesn't work because of

renovate/lib/modules/platform/gitea/index.ts

Line 435 in c93ae91

ccs.statuses.every((status) => status.context?.startsWith('renovate/'))

dh-harald Jan 11, 2025
Author

Example

curl -k -H 'Content-Type: application/json' 'https://gitea.self.hosted/api/v1/repos/k8s/manifests/commits/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1/status' | jq .
{
  "state": "success",
  "sha": "4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
  "total_count": 19,
  "statuses": [
    {
      "id": 29,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/0",
      "description": "Successful in 9s",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / prepare (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:29:02Z",
      "updated_at": "2025-01-10T18:29:02Z"
    },
    {
      "id": 48,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0000_crd) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:13Z",
      "updated_at": "2025-01-10T18:31:13Z"
    },
    {
      "id": 67,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/2",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0001_flannel) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:15Z",
      "updated_at": "2025-01-10T18:31:15Z"
    },
    {
      "id": 68,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/3",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0010_local-path-provisioner) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:17Z",
      "updated_at": "2025-01-10T18:31:17Z"
    },
    {
      "id": 69,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/4",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0020_replicator) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:19Z",
      "updated_at": "2025-01-10T18:31:19Z"
    },
    {
      "id": 70,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/5",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0030_cert-manager) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:22Z",
      "updated_at": "2025-01-10T18:31:22Z"
    },
    {
      "id": 71,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/6",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0031_cert-manager-webhook) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:23Z",
      "updated_at": "2025-01-10T18:31:23Z"
    },
    {
      "id": 72,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/7",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0040_ingress-nginx) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:25Z",
      "updated_at": "2025-01-10T18:31:25Z"
    },
    {
      "id": 73,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/8",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0100_mariadb) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:27Z",
      "updated_at": "2025-01-10T18:31:27Z"
    },
    {
      "id": 74,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/9",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0110_redis) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:29Z",
      "updated_at": "2025-01-10T18:31:29Z"
    },
    {
      "id": 75,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/10",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0120_memcached) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:31Z",
      "updated_at": "2025-01-10T18:31:31Z"
    },
    {
      "id": 76,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/11",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0200_pdns) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:33Z",
      "updated_at": "2025-01-10T18:31:33Z"
    },
    {
      "id": 77,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/12",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0210_mail) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:35Z",
      "updated_at": "2025-01-10T18:31:35Z"
    },
    {
      "id": 78,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/13",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0300_poweradmin) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:31:38Z",
      "updated_at": "2025-01-10T18:31:38Z"
    },
    {
      "id": 79,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/14",
      "description": "Successful in 1m19s",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0310_postfixadmin) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:32:59Z",
      "updated_at": "2025-01-10T18:32:59Z"
    },
    {
      "id": 80,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/15",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0320_gitea) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:33:00Z",
      "updated_at": "2025-01-10T18:33:00Z"
    },
    {
      "id": 81,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/16",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0321-gitea-runner-alpine) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:33:02Z",
      "updated_at": "2025-01-10T18:33:02Z"
    },
    {
      "id": 82,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/17",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / test (0322-gitea-runner-k8s) (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:33:04Z",
      "updated_at": "2025-01-10T18:33:04Z"
    },
    {
      "id": 83,
      "status": "success",
      "target_url": "/k8s/manifests/actions/runs/47/jobs/18",
      "description": "Has been skipped",
      "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
      "context": "testing / cleanup (pull_request)",
      "creator": null,
      "created_at": "2025-01-10T18:33:05Z",
      "updated_at": "2025-01-10T18:33:05Z"
    }
  ],
  "repository": {
[...]

dh-harald Jan 11, 2025
Author

@viceice I've checked the data, and you've right, i've data with the same timestamp:

  {
    "id": 47,
    "status": "pending",
    "target_url": "/k8s/manifests/actions/runs/47/jobs/1",
    "description": "Has started running",
    "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
    "context": "testing / test (0000_crd) (pull_request)",
    "creator": null,
    "created_at": "2025-01-10T18:31:13Z",
    "updated_at": "2025-01-10T18:31:13Z"
  },
  {
    "id": 48,
    "status": "success",
    "target_url": "/k8s/manifests/actions/runs/46/jobs/1",
    "description": "Has been skipped",
    "url": "https://gitea.self.hosted/api/v1/repos/k8s/manifests/statuses/4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1",
    "context": "testing / test (0000_crd) (pull_request)",
    "creator": null,
    "created_at": "2025-01-10T18:31:13Z",
    "updated_at": "2025-01-10T18:31:13Z"
  },

It looks, in some cases the skipped step could have same timestamp for pending and success state
This could be the reason, why sometimes passes the check, sometimes isn't.
Precision is only a second, so it could happen

dh-harald Jan 11, 2025
Author

Based on gitea, they use id instead of create/update date:
https://github.com/go-gitea/gitea/blob/5c150ce9b0c9df32ebeebacdc31f44a32dc7fa15/models/git/commit_status.go#L302

(in database field index is the id in the API response)

I'm still thinking, that https://demo.gitea.com/api/swagger#/repository/repoGetCombinedStatusByRef would be better as you could skip the whole filter logic

dh-harald Jan 12, 2025
Author

EDIT: i've updated the OP with the relevant section which (I think) causing the problem

rarkins · 2025-01-14T13:06:53Z

rarkins
Jan 14, 2025
Maintainer

If I've understood the above, the simplest solution is to enhance this function:

renovate/lib/modules/platform/gitea/gitea-helper.ts

Lines 394 to 404 in c93ae91

    
           function filterStatus(data: CommitStatus[]): CommitStatus[] { 
        
             const ret: Record<string, CommitStatus> = {}; 
        
             for (const i of data) { 
        
               if ( 
        
                 !ret[i.context] || 
        
                 new Date(ret[i.context].created_at) < new Date(i.created_at) 
        
               ) { 
        
                 ret[i.context] = i; 
        
               } 
        
             } 
        
             return Object.values(ret);

So that if timestamps are the same then "passed" takes priority in the filtering.

4 replies

dh-harald Jan 14, 2025
Author

If you want to keep up filtering, definetely needs to use id instead of created_at (or updated_at)

rarkins Jan 14, 2025
Maintainer

Do you mean that id is a more reliable way to determine that a result is "newer" if context matches?

dh-harald Jan 14, 2025
Author

based on how gitea implemented it (https://github.com/go-gitea/gitea/blob/5c150ce9b0c9df32ebeebacdc31f44a32dc7fa15/models/git/commit_status.go#L302), yes

dh-harald Jan 14, 2025
Author

MariaDB [gitea]> SELECT `index`, `state`, `sha`, `context`, `created_unix` FROM `commit_status`
    -> WHERE sha='4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1'
    -> AND `context`='testing / test (0000_crd) (pull_request)' ORDER BY `index`;
+-------+---------+------------------------------------------+------------------------------------------+--------------+
| index | state   | sha                                      | context                                  | created_unix |
+-------+---------+------------------------------------------+------------------------------------------+--------------+
|     2 | pending | 4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1 | testing / test (0000_crd) (pull_request) |   1736533673 |
|    30 | success | 4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1 | testing / test (0000_crd) (pull_request) |   1736533747 |
|    47 | pending | 4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1 | testing / test (0000_crd) (pull_request) |   1736533873 |
|    48 | success | 4f4169856acc5eb4e64f3ae74ac26fc9dd230bf1 | testing / test (0000_crd) (pull_request) |   1736533873 |
+-------+---------+------------------------------------------+------------------------------------------+--------------+
4 rows in set (0.005 sec)

rarkins · 2025-01-14T16:15:48Z

rarkins
Jan 14, 2025
Maintainer

Converted to issue: #33613

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parsing gitea status checks is wrong #33531

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 3 comments 27 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Parsing gitea status checks is wrong #33531

dh-harald Jan 11, 2025

How are you running Renovate?

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Please tell us more about your question or problem

Logs (if relevant)

Replies: 3 comments · 27 replies

rarkins Jan 11, 2025 Maintainer

viceice Jan 11, 2025 Maintainer

dh-harald Jan 11, 2025 Author

dh-harald Jan 11, 2025 Author

dh-harald Jan 11, 2025 Author

dh-harald Jan 12, 2025 Author

rarkins Jan 14, 2025 Maintainer

dh-harald Jan 14, 2025 Author

rarkins Jan 14, 2025 Maintainer

dh-harald Jan 14, 2025 Author

dh-harald Jan 14, 2025 Author

rarkins Jan 14, 2025 Maintainer

dh-harald
Jan 11, 2025

Replies: 3 comments 27 replies

rarkins
Jan 11, 2025
Maintainer

viceice Jan 11, 2025
Maintainer

dh-harald Jan 11, 2025
Author

dh-harald Jan 11, 2025
Author

dh-harald Jan 11, 2025
Author

dh-harald Jan 12, 2025
Author

rarkins
Jan 14, 2025
Maintainer

dh-harald Jan 14, 2025
Author

rarkins Jan 14, 2025
Maintainer

dh-harald Jan 14, 2025
Author

dh-harald Jan 14, 2025
Author

rarkins
Jan 14, 2025
Maintainer