Skip to content

Fix total count value returned in book listing endpoint #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
repl opened this issue Apr 4, 2019 · 8 comments
Open

Fix total count value returned in book listing endpoint #1

repl opened this issue Apr 4, 2019 · 8 comments
Labels
beginner easy good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@repl
Copy link
Owner

repl commented Apr 4, 2019

The endpoint /api/v1/books' returns books in a paginated way and each response payload also includes an attribute total count which will help the caller to show the total number of pages. The total count needs to be calculated using mongodb operations using spring data methods.

@repl repl added beginner easy good first issue Good for newcomers up-for-grabs help wanted Extra attention is needed labels Apr 4, 2019
@shivam15
Copy link

shivam15 commented Apr 6, 2019

I would like to take this please assign it to me.

@repl
Copy link
Owner Author

repl commented Apr 6, 2019

@shivam15 Thank you for your interest. You will have to add a few records in your local mongodb (see README). Please go ahead and create a PR.

@shivam15
Copy link

@repl can you update readme for deploying scala backend?

@repl
Copy link
Owner Author

repl commented Apr 12, 2019

@shivam15 The service is run using bootRun task of gradle. I have updated the readme as well.

shivam15 added a commit to shivam15/Springboot-Scala-MongoDB that referenced this issue Apr 13, 2019
@shivam15
Copy link

@repl created pull request please check.

@repl
Copy link
Owner Author

repl commented Apr 13, 2019 via email

@shivam15
Copy link

Do you think its possible since you are passing limit and skip in the first query. How will you get total count in same?

@repl
Copy link
Owner Author

repl commented Apr 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner easy good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants