fix: simplify ReadableStream source constructor

Author: jderochervlk

docs/content/docs/contributing/api-modelling.mdx

@@ -63,7 +63,7 @@ When naming an overloaded function, we can use the `With` suffix to indicate tha
 Constructors follow a different naming rule than methods.
 
 - Keep singleton constructors named `make`.
-- Keep true default constructors named `make`, even when the constructor family also has typed overloads.
+- Keep true no-argument default constructors named `make`, even when the constructor family also has typed overloads.
 - When a constructor family does not have a default constructor, use `from*` names for every overload, including the first one.
 - Base `from*` names on the source input type: `fromString`, `fromArrayBuffer`, `fromMediaStream`, `fromURLWithProtocols`, and so on.
 - If an optional labeled argument hides a real default constructor, split that binding into `make()` plus typed `from*` overloads instead of keeping the optional argument on `make`.

packages/File/src/ReadableStream.res

@@ -18,38 +18,23 @@ let stream: ReadableStream.t<string> = ReadableStream.make()
 external make: unit => t<'t> = "ReadableStream"
 
 /**
-`fromUnderlyingSource(underlyingSource<'t>)`
+`fromUnderlyingSource(underlyingSource<'t>, ~strategy: queuingStrategy<'t>=?)`
 
-Creates a new `ReadableStream` from an `underlyingSource`.
+Creates a new `ReadableStream` from an `underlyingSource`, with an optional queuing strategy.
 
 ```res
 let stream = ReadableStream.fromUnderlyingSource(myUnderlyingSource)
-```
-
-[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream)
-*/
-@new
-external fromUnderlyingSource: Types.underlyingSource<'t> => t<'t> = "ReadableStream"
 
-/**
-`fromUnderlyingSourceWithStrategy(~underlyingSource: underlyingSource<'t>, ~strategy: queuingStrategy<'t>)`
-
-Creates a new `ReadableStream` from an `underlyingSource` and `queuingStrategy`.
-
-```res
-let stream =
-  ReadableStream.fromUnderlyingSourceWithStrategy(
-    ~underlyingSource=myUnderlyingSource,
-    ~strategy=myQueuingStrategy,
-  )
+let streamWithStrategy =
+  ReadableStream.fromUnderlyingSource(myUnderlyingSource, ~strategy=myQueuingStrategy)
 ```
 
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream)
 */
 @new
-external fromUnderlyingSourceWithStrategy: (
-  ~underlyingSource: Types.underlyingSource<'t>,
-  ~strategy: Types.queuingStrategy<'t>,
+external fromUnderlyingSource: (
+  Types.underlyingSource<'t>,
+  ~strategy: Types.queuingStrategy<'t>=?,
 ) => t<'t> = "ReadableStream"
 
 /**

tests/FileAPI/ReadableStream__test.res

@@ -5,7 +5,7 @@ let _make: WebApiFile.ReadableStream.t<string> = WebApiFile.ReadableStream.make(
 
 let _fromUnderlyingSource = WebApiFile.ReadableStream.fromUnderlyingSource(underlyingSource)
 
-let _fromUnderlyingSourceWithStrategy = WebApiFile.ReadableStream.fromUnderlyingSourceWithStrategy(
-  ~underlyingSource,
+let _fromUnderlyingSourceWithStrategy = WebApiFile.ReadableStream.fromUnderlyingSource(
+  underlyingSource,
   ~strategy,
 )