From 2fe6c4acf4d1bd87692ad47b2f85dfe3d98d14e0 Mon Sep 17 00:00:00 2001 From: nojaf Date: Sat, 26 Apr 2025 17:54:04 +0200 Subject: [PATCH] Rename _useCapture --- docs/content/docs/contributing/api-modelling.mdx | 8 ++------ src/EventAPI/EventTarget.res | 2 +- src/Global.res | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/content/docs/contributing/api-modelling.mdx b/docs/content/docs/contributing/api-modelling.mdx index 4b70ade..b0f33ff 100644 --- a/docs/content/docs/contributing/api-modelling.mdx +++ b/docs/content/docs/contributing/api-modelling.mdx @@ -48,7 +48,7 @@ We can use [a fixed argument](https://rescript-lang.org/docs/manual/latest/bind- ```ReScript @send -external addEventListener_useCapture: ( +external addEventListenerWithCapture: ( htmlButtonElement, ~type_: eventType, ~callback: eventListener<'event>, @@ -56,11 +56,7 @@ external addEventListener_useCapture: ( ) => unit = "addEventListener" ``` - +When naming an overloaded function, we can use the `With` suffix to indicate that it is an overloaded function. ### Decoded variants diff --git a/src/EventAPI/EventTarget.res b/src/EventAPI/EventTarget.res index 8f3677c..8292326 100644 --- a/src/EventAPI/EventTarget.res +++ b/src/EventAPI/EventTarget.res @@ -54,7 +54,7 @@ The event listener is appended to target's event listener list and is not append [Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/addEventListener) */ @send - external addEventListener_useCapture: ( + external addEventListenerWithCapture: ( T.t, eventType, eventListener<'event>, diff --git a/src/Global.res b/src/Global.res index 2b7d808..f213762 100644 --- a/src/Global.res +++ b/src/Global.res @@ -554,7 +554,7 @@ If an AbortSignal is passed for options's signal, then the event listener will b The event listener is appended to target's event listener list and is not appended if it has the same type, callback, and capture. [Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/addEventListener) */ -external addEventListener_useCapture: ( +external addEventListenerWithCapture: ( eventType, eventListener<'event>, @as(json`true`) _,