Remove reduce in BlogApi RSS XML building

Author: chenglou

src/common/BlogApi.mjs

@@ -82,14 +82,14 @@ function toXmlString(siteTitleOpt, siteDescriptionOpt, items) {
               var latestPubDateStr = dateToUTCString(item.pubDate);
               return "<lastBuildDate>" + latestPubDateStr + "</lastBuildDate>";
             })), "");
-  var itemsStr = Belt_Array.reduce(items, "", (function (acc, item) {
-          var description = item.description;
-          var href = item.href;
-          var descriptionElement = description === "" ? "" : "<description>\n          <![CDATA[" + description + "]]>\n        </description>";
-          var dateStr = dateToUTCString(item.pubDate);
-          return acc + ("\n      <item>\n        <title> <![CDATA[" + item.title + "]]></title>\n        <link> " + href + " </link>\n        <guid> " + href + " </guid>\n        " + descriptionElement + "\n        <pubDate>" + dateStr + "</pubDate>\n      </item>");
-        }));
-  return "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n  <rss version=\"2.0\">\n    <channel>\n        <title>" + siteTitle + "</title>\n        <link>https://rescript-lang.org</link>\n        <description>" + siteDescription + "</description>\n        <language>en</language>\n        " + latestPubDateElement + "\n" + itemsStr + "\n    </channel>\n  </rss>";
+  var itemsStr = items.map(function (param) {
+          var description = param.description;
+          var href = param.href;
+          var descriptionElement = description === "" ? "" : "<description>\n            <![CDATA[" + description + "]]>\n          </description>";
+          var dateStr = dateToUTCString(param.pubDate);
+          return "\n        <item>\n          <title> <![CDATA[" + param.title + "]]></title>\n          <link> " + href + " </link>\n          <guid> " + href + " </guid>\n          " + descriptionElement + "\n          <pubDate>" + dateStr + "</pubDate>\n        </item>";
+        }).join("\n");
+  return "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n  <rss version=\"2.0\">\n    <channel>\n      <title>" + siteTitle + "</title>\n      <link>https://rescript-lang.org</link>\n      <description>" + siteDescription + "</description>\n      <language>en</language>\n      " + latestPubDateElement + "\n" + itemsStr + "\n    </channel>\n  </rss>";
 }
 
 var RssFeed = {

src/common/BlogApi.res

@@ -138,36 +138,37 @@ module RssFeed = {
       })
       ->Belt.Option.getWithDefault("")
 
-    let itemsStr = Belt.Array.reduce(items, "", (acc, item) => {
-      let {title, pubDate, description, href} = item
-
-      let descriptionElement = switch description {
-      | "" => ""
-      | desc => j`<description>
-          <![CDATA[$desc]]>
-        </description>`
-      }
+    let itemsStr =
+      items
+      ->Js.Array2.map(({title, pubDate, description, href}) => {
+        let descriptionElement = switch description {
+        | "" => ""
+        | desc => j`<description>
+            <![CDATA[$desc]]>
+          </description>`
+        }
 
-      // TODO: convert pubdate to string
-      let dateStr = pubDate->dateToUTCString
-      j`${acc}
-      <item>
-        <title> <![CDATA[$title]]></title>
-        <link> $href </link>
-        <guid> $href </guid>
-        $descriptionElement
-        <pubDate>$dateStr</pubDate>
-      </item>`
-    })
+        // TODO: convert pubdate to string
+        let dateStr = pubDate->dateToUTCString
+        j`
+        <item>
+          <title> <![CDATA[$title]]></title>
+          <link> $href </link>
+          <guid> $href </guid>
+          $descriptionElement
+          <pubDate>$dateStr</pubDate>
+        </item>`
+      })
+      ->Js.Array2.joinWith("\n")
 
     let ret = j`<?xml version="1.0" encoding="utf-8" ?>
   <rss version="2.0">
     <channel>
-        <title>$siteTitle</title>
-        <link>https://rescript-lang.org</link>
-        <description>$siteDescription</description>
-        <language>en</language>
-        $latestPubDateElement
+      <title>$siteTitle</title>
+      <link>https://rescript-lang.org</link>
+      <description>$siteDescription</description>
+      <language>en</language>
+      $latestPubDateElement
 $itemsStr
     </channel>
   </rss>` //rescript-lang.org</link>