Skip to content

Implement our own JSON schema validation to use the correct build-schema.json for the installed compiler version #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Implement our own JSON schema validation to use the correct build-schema.json for the installed compiler version #1131

wants to merge 7 commits into from

Conversation

fhammerschmidt
Copy link
Member

Fixes #1110

@fhammerschmidt fhammerschmidt changed the title Use the correct build-schema.json for the installed compiler version WIP: Use the correct build-schema.json for the installed compiler version Sep 26, 2025
@fhammerschmidt fhammerschmidt marked this pull request as draft September 26, 2025 08:27
@fhammerschmidt
Copy link
Member Author

will try a different approach (the same as TS LSP)

@fhammerschmidt fhammerschmidt changed the title WIP: Use the correct build-schema.json for the installed compiler version Implement our own JSON schema validation to use the correct build-schema.json for the installed compiler version Sep 29, 2025
@fhammerschmidt fhammerschmidt marked this pull request as ready for review September 29, 2025 21:14
@cknitt
Copy link
Member

cknitt commented Sep 30, 2025

@codex review

@chatgpt-codex-connector ChatGPT Codex Connector
Copy link

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@nojaf
Copy link
Member

nojaf commented Oct 1, 2025

image

Can we scope this to node we are currently in?
I'm getting autocomplete for everything top level now, I need to see the jsx specific things that are not yet used.

@fhammerschmidt
Copy link
Member Author

@nojaf feel free to test again.

@cknitt
Copy link
Member

cknitt commented Oct 3, 2025

@codex review

@chatgpt-codex-connector ChatGPT Codex Connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@nojaf
Copy link
Member

nojaf commented Oct 3, 2025

I still see this thing first try:
image

Inside empty quotes, the completion of editor adds an additional quote:
image

@fhammerschmidt
Copy link
Member Author

Of course it only works in the jsx property and not in the more advanced cases, adding proper tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt Awaiting requested review from cknitt

@zth zth Awaiting requested review from zth

@nojaf nojaf Awaiting requested review from nojaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build schema is always taken from the compiler's latest master
3 participants
@fhammerschmidt @cknitt @nojaf