Suggestion: separate packages for prebuilt binaries. #6133
Labels
stale
Old issues that went stale
Comments
|
CC @cknitt |
|
@cometkim Interesting, did not know about this. Thanks for the suggestion! (Note that even though ReScript 11 has prebuilt binaries for more platforms than ReScript 10.1, the package size is still a lot smaller - 29.2 MB vs. 47.1 MB.) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this as it duplicates #6183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
rescriptpackage provides prebuilt binaries for major platforms.Not relying on the postinstall hook is good, but it significantly increases package installation time. An additional 20-30MB of bandwidth per platform is required for it.
Installing binaries for not matched platforms is obviously unnecessary work, so users can skip close to 100MB of downloading by omitting 4 out of 5 supported platforms.
Thankfully Yarn & pnpm support feature for this (I'm not sure npm also does). They can skip installation if the
osandcpuentries specified in thepackage.jsondo not match (and this behavior can be customized)Packages using prebuilt bins like esbuild provide it separately in the form of
@esbuild/{os}-{cpu}for this purpose.So
@esbuild/linux-x64'spackage.json:{ "name": "@esbuild/linux-x64", "version": "0.17.16", "description": "The Linux 64-bit binary for esbuild, a JavaScript bundler.", "repository": "https://github.com/evanw/esbuild", "license": "MIT", "preferUnplugged": true, "engines": { "node": ">=12" }, "os": [ "linux" ], "cpu": [ "x64" ] }And
esbuild's:It is specified as
optionalDependenciesbecause it can be omitted depending on the environment.As the result, when I run
yarn add esbuildon my env, I can see yarn only install@esbuild/linux-x64additionallyThe downside of this approach is that it makes the release workflow more complex.
The text was updated successfully, but these errors were encountered: