using background tokens for icons?

[egucciar]

Is it strange that we're using background tokens on icons? we found for things like critical, a solid background color in darkmode looks better than our foreground text color for icons...this is mainly for icons next to neutral colored text though

[blvdmitry]

It always depends on the color contrast and text has the same contrast ratio requirements as icons so they're expected to rely on the same color tokens. If you think bg colors work better, I would start by checking if foreground tokens in your theme could use values closer to bg values