Test branch #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

acse-dc1823 wants to merge 3 commits into rhodrin:master from acse-dc1823:test_branch

README.md

-Original file line number
+Diff line change
@@ -1,2 +1,4 @@
     # CI MPM
     Toy repo with some simple functions for the CI lecture
+    Changesj made..2f

simple_functions/functions1.py

-Original file line number
+Diff line change
@@ -1,9 +1,15 @@
+    from functools import cache
-    __all__ = ['my_sum']
+    __all__ = ['my_sum', 'factorial']
     def my_sum(iterable):
         tot = 0
         for i in iterable:
             tot += i
         return tot
+    @cache
+    def factorial(n):
+        return n * factorial(n-1) if n else 1

tests/test_simple_functions.py

-Original file line number
+Diff line change
@@ -1,6 +1,6 @@
     import pytest
-    from simple_functions import my_sum
+    from simple_functions import my_sum, factorial
     class TestSimpleFunctions(object):
@@ Expand All / @@ -14,3 +14,15 @@ def test_my_add(self, iterable, expected): @@
             '''Test our add function'''
             isum = my_sum(iterable)
             assert isum == expected
+        @pytest.mark.parametrize('number, expected', [
+            (5, 120),
+            (3, 6),
+            (1, 1)
+        ])
+        def test_factorial(self, number, expected):
+            '''Test our factorial function'''
+            answer = factorial(number)
+            #fbanassssss
+            assert answer==expected

Provide feedback