Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components and npm modules are not updated #18

Open
jfresco opened this issue Jan 29, 2015 · 2 comments
Open

Components and npm modules are not updated #18

jfresco opened this issue Jan 29, 2015 · 2 comments

Comments

@jfresco
Copy link

jfresco commented Jan 29, 2015

When you add a new component or npm module and run make, component install and npm install are not executed if components and node_modules directories exists.
As a workaround, you have to run make clean && make, delete the directories manually or run component install and/or npm install.

I think it is due to node_modules and components Makefile targets are not PHONY. According to GNU make docs, when targets are executed, make looks for a file with the target name, and if it exists, the target is not executed unless is PHONY.
In this case, make components is generating a components directory, so when this directory exists, components target is bypassed. Same thing with node_modules.

jfresco added a commit to jfresco/nodejs-starter that referenced this issue Jan 29, 2015
@xasos
Copy link

xasos commented Apr 5, 2015

+1

@cristiandouce
Copy link
Collaborator

@jfresco this was made on purpose since you don't want component install and npm install to be executed every time you run your app. Only when you update your dependencies, and specially on development where you stop and start the process many times.

The Makefile was inteded to be used only for development. So I don't see the harm on leaving it like it is now.

npm install and component install tasks take some time to run. In development on each stop/start you want it to be executed as fast as possible, since you may be executing/drive testing code for the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants