No "thru" punct when composing #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 |
|
Bump. Is there any blocker for this issue? How can we expect this will be merged, just a polite ask. |
bczhc
added a commit
to bczhc/rime-android
that referenced
this pull request
Sep 4, 2024
since rime/librime#672 hasn't got merged
lotem
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #670 fixes rime/squirrel#785
Feature
Do not use ascii punctuators after numerals when user is already composing (but have not yet committed any input), in which case the punctuator may actually commit the composed string.
In addition to
.(decimal point / grouping separator) and:(time separator), two similar punctuators are also included —,(grouping separator / decimal comma) and'(another form of grouping separator).Unit test
Manual test
Code Review
Additional Info