feat(table_translator): Allow sorting completions #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'f' for kFuzzySpelling
Add a new boolean option `sort_completions`. When enabled (requiring `enable_completion` also to be enabled), completion candidates will be sorted according to the weights specified in the dictionary. This is done by automatically generating kCompletion spellings in the prism, as if they were generated from spelling algebra written by the user. Previously, the order was arbitrary (but more-or-less in alphabet order).
|
Upon further testing, this doesn't work with custom algebra: derive/de/bb/, type single b, get wrong comment: 
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #820
Feature
Describe feature of pull request
Add a new boolean option
sort_completions. When enabled (requiringenable_completionalso to be enabled), completion candidates will besorted according to the weights specified in the dictionary.
This is done by automatically generating kCompletion spellings in the
prism, as if they were generated from spelling algebra written by the
user.
Previously, the order was arbitrary (but more-or-less in alphabet
order).
Unit test
Manual test
Code Review
Additional Info