Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor's back_syllable removes multiple syllables when selecting a shorter candidate #910

Open
1 task done
EtaoinWu opened this issue Jul 5, 2024 · 1 comment
Open
1 task done
Labels

Comments

@EtaoinWu
Copy link

EtaoinWu commented Jul 5, 2024

Describe the bug
When multiple syllables are typed and the selector is used to select a shorter candidate, this would leave some unused syllables un-highlighted.

Illustration of the bug condition

If the back_syllable action of the editor is invoked, for example by hitting {Control+BackSpace}, all the unhighlighted syllables (in this case shu'ru) are removed, instead of only one of them.

To Reproduce
Steps to reproduce the bug:

  1. This should happen also on the default configuration with stock luna_pinyin. I tested this on weasel 0.16.1 and librime 1.11.2.
  2. Type ce'shi'shu'ru.
  3. Use {Down} until you select the word 測試.
  4. Hit {Control+BackSpace} to invoke back_syllable and observe that shu'ru is removed, leaving only ce'shi in the input.

Expected behavior
Only one syllable (in our case shi) shall be removed.

Flavor(please complete the following information):
Select your flavor:

  • Weasel 0.16.1

Package:

  • OS: Windows 11 version 22H2 build 22621.3672
  • Version: librime 1.11.2
@EtaoinWu EtaoinWu added the bug label Jul 5, 2024
@ksqsf
Copy link
Member

ksqsf commented Jul 14, 2024

I think this is intended. Note that the caret is still at the end of the input. If you move the caret after "shi" and then hit Ctrl+BackSpace, it will work as you expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants