You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm interested in your hummock engine. After taking a brief look into the code of meta I found most of the network addresses are String typed.
Typing network addresses with std::net::SocketAddr could represent them as 16-bytes-sized enums and 2-bytes-sized port numbers in memory, saving space and time on heap allocations or deallocations. And comparing between addresses could be faster since much fewer reads are required.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm interested in your
hummock
engine. After taking a brief look into the code ofmeta
I found most of the network addresses areString
typed.Typing network addresses with
std::net::SocketAddr
could represent them as 16-bytes-sized enums and 2-bytes-sized port numbers in memory, saving space and time on heap allocations or deallocations. And comparing between addresses could be faster since much fewer reads are required.Beta Was this translation helpful? Give feedback.
All reactions