Skip to content

Commit f4fe8aa

Browse files
committed
fix: fix connection dead
1 parent 0654185 commit f4fe8aa

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

clients/openapi/openapi.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,15 @@
2424
"schema": {
2525
"type": "string"
2626
},
27-
"required": true,
27+
"required": false,
28+
"name": "actor_ids",
29+
"in": "query"
30+
},
31+
{
32+
"schema": {
33+
"type": "string"
34+
},
35+
"required": false,
2836
"name": "key",
2937
"in": "query"
3038
}

packages/rivetkit/src/actor/instance.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ export type ExtractActorState<A extends AnyActorInstance> =
8484
// biome-ignore lint/suspicious/noExplicitAny: Must be used for `extends`
8585
any
8686
>
87-
? State
88-
: never;
87+
? State
88+
: never;
8989

9090
export type ExtractActorConnParams<A extends AnyActorInstance> =
9191
A extends ActorInstance<
@@ -101,8 +101,8 @@ export type ExtractActorConnParams<A extends AnyActorInstance> =
101101
// biome-ignore lint/suspicious/noExplicitAny: Must be used for `extends`
102102
any
103103
>
104-
? ConnParams
105-
: never;
104+
? ConnParams
105+
: never;
106106

107107
export type ExtractActorConnState<A extends AnyActorInstance> =
108108
A extends ActorInstance<
@@ -118,8 +118,8 @@ export type ExtractActorConnState<A extends AnyActorInstance> =
118118
// biome-ignore lint/suspicious/noExplicitAny: Must be used for `extends`
119119
any
120120
>
121-
? ConnState
122-
: never;
121+
? ConnState
122+
: never;
123123

124124
export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
125125
// Shared actor context for this instance
@@ -1145,15 +1145,15 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
11451145
}
11461146

11471147
// Connection is dead, remove it
1148-
this.#rLog.warn({
1149-
msg: "connection is dead, removing",
1150-
connId: conn.id,
1151-
lastSeen,
1152-
});
1148+
// this.#rLog.warn({
1149+
// msg: "connection is dead, removing",
1150+
// connId: conn.id,
1151+
// lastSeen,
1152+
// });
11531153

11541154
// TODO: Do we need to force disconnect the connection here?
11551155

1156-
this.__removeConn(conn);
1156+
// this.__removeConn(conn);
11571157
}
11581158
}
11591159
}
@@ -1367,14 +1367,14 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
13671367
try {
13681368
websocket.removeEventListener("close", onSocketClosed);
13691369
websocket.removeEventListener("error", onSocketClosed);
1370-
} catch {}
1370+
} catch { }
13711371
this.#activeRawWebSockets.delete(websocket);
13721372
this.#resetSleepTimer();
13731373
};
13741374
try {
13751375
websocket.addEventListener("close", onSocketClosed);
13761376
websocket.addEventListener("error", onSocketClosed);
1377-
} catch {}
1377+
} catch { }
13781378

13791379
// Handle WebSocket
13801380
await this.#config.onWebSocket(this.actorContext, websocket, opts);
@@ -1672,7 +1672,7 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
16721672
// Abort any listeners waiting for shutdown
16731673
try {
16741674
this.#abortController.abort();
1675-
} catch {}
1675+
} catch { }
16761676

16771677
// Call onStop lifecycle hook if defined
16781678
if (this.#config.onStop) {

0 commit comments

Comments
 (0)